-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unsupported examples #26075
Merged
timneutkens
merged 5 commits into
vercel:canary
from
timneutkens:fix/remove-unsupported-examples
Jun 14, 2021
Merged
Remove unsupported examples #26075
timneutkens
merged 5 commits into
vercel:canary
from
timneutkens:fix/remove-unsupported-examples
Jun 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stats from current PRDefault Server Mode (Decrease detected ✓)General Overall increase
|
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
buildDuration | 14.1s | 14s | -72ms |
buildDurationCached | 3.3s | 3.3s | -44ms |
nodeModulesSize | 46.5 MB | 46.5 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.698 | 2.724 | |
/ avg req/sec | 926.48 | 917.83 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.682 | 1.681 | 0 |
/error-in-render avg req/sec | 1485.96 | 1487.58 | +1.62 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
framework-HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
main-HASH.js gzip | 20.2 kB | 20.2 kB | ✓ |
webpack-HASH.js gzip | 804 B | 804 B | ✓ |
Overall change | 60.3 kB | 60.3 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
_app-HASH.js gzip | 801 B | 801 B | ✓ |
_error-HASH.js gzip | 3.18 kB | 3.18 kB | ✓ |
amp-HASH.js gzip | 527 B | 527 B | ✓ |
css-HASH.js gzip | 334 B | 334 B | ✓ |
hooks-HASH.js gzip | 890 B | 890 B | ✓ |
index-HASH.js gzip | 263 B | 263 B | ✓ |
link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..HASH.js gzip | 333 B | 333 B | ✓ |
withRouter-HASH.js gzip | 330 B | 330 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 8.43 kB | 8.43 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
_buildManifest.js gzip | 395 B | 395 B | ✓ |
Overall change | 395 B | 395 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
index.html gzip | 522 B | 522 B | ✓ |
link.html gzip | 535 B | 535 B | ✓ |
withRouter.html gzip | 516 B | 516 B | ✓ |
Overall change | 1.57 kB | 1.57 kB | ✓ |
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
buildDuration | 15.7s | 15.8s | |
buildDurationCached | 4.3s | 4.4s | |
nodeModulesSize | 46.5 MB | 46.5 MB |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
framework-HASH.js gzip | 39.3 kB | 39.3 kB | ✓ |
main-HASH.js gzip | 20.2 kB | 20.2 kB | ✓ |
webpack-HASH.js gzip | 804 B | 804 B | ✓ |
Overall change | 60.3 kB | 60.3 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.1 kB | 31.1 kB | ✓ |
Overall change | 31.1 kB | 31.1 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
_app-HASH.js gzip | 801 B | 801 B | ✓ |
_error-HASH.js gzip | 3.18 kB | 3.18 kB | ✓ |
amp-HASH.js gzip | 527 B | 527 B | ✓ |
css-HASH.js gzip | 334 B | 334 B | ✓ |
hooks-HASH.js gzip | 890 B | 890 B | ✓ |
index-HASH.js gzip | 263 B | 263 B | ✓ |
link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..HASH.js gzip | 333 B | 333 B | ✓ |
withRouter-HASH.js gzip | 330 B | 330 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 8.43 kB | 8.43 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
_buildManifest.js gzip | 395 B | 395 B | ✓ |
Overall change | 395 B | 395 B | ✓ |
Serverless bundles
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
_error.js | 16.9 kB | 16.9 kB | ✓ |
404.html | 1.98 kB | 1.98 kB | ✓ |
500.html | 1.96 kB | 1.96 kB | ✓ |
amp.amp.html | 10.8 kB | 10.8 kB | ✓ |
amp.html | 1.17 kB | 1.17 kB | ✓ |
css.html | 1.35 kB | 1.35 kB | ✓ |
hooks.html | 1.23 kB | 1.23 kB | ✓ |
index.js | 17.2 kB | 17.2 kB | ✓ |
link.js | 17.4 kB | 17.4 kB | -2 B |
routerDirect.js | 17.4 kB | 17.4 kB | |
withRouter.js | 17.4 kB | 17.4 kB | ✓ |
Overall change | 105 kB | 105 kB | ✓ |
Webpack 4 Mode (Increase detected ⚠️ )
General Overall increase ⚠️
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
buildDuration | 12.2s | 12.2s | -20ms |
buildDurationCached | 5.1s | 4.8s | -258ms |
nodeModulesSize | 46.5 MB | 46.5 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.752 | 2.663 | -0.09 |
/ avg req/sec | 908.43 | 938.75 | +30.32 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.633 | 1.605 | -0.03 |
/error-in-render avg req/sec | 1530.5 | 1558.12 | +27.62 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
677f882d2ed8..HASH.js gzip | 13.4 kB | 13.4 kB | ✓ |
framework.HASH.js gzip | 39 kB | 39 kB | ✓ |
main-HASH.js gzip | 7.99 kB | 7.99 kB | ✓ |
webpack-HASH.js gzip | 751 B | 751 B | ✓ |
Overall change | 61.1 kB | 61.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31.3 kB | 31.3 kB | ✓ |
Overall change | 31.3 kB | 31.3 kB | ✓ |
Client Pages
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
_app-HASH.js gzip | 1.07 kB | 1.07 kB | ✓ |
_error-HASH.js gzip | 3.85 kB | 3.85 kB | ✓ |
amp-HASH.js gzip | 536 B | 536 B | ✓ |
css-HASH.js gzip | 339 B | 339 B | ✓ |
hooks-HASH.js gzip | 887 B | 887 B | ✓ |
index-HASH.js gzip | 227 B | 227 B | ✓ |
link-HASH.js gzip | 1.63 kB | 1.63 kB | ✓ |
routerDirect..HASH.js gzip | 303 B | 303 B | ✓ |
withRouter-HASH.js gzip | 302 B | 302 B | ✓ |
e025d2764813..52f.css gzip | 125 B | 125 B | ✓ |
Overall change | 9.28 kB | 9.28 kB | ✓ |
Client Build Manifests
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
_buildManifest.js gzip | 420 B | 420 B | ✓ |
Overall change | 420 B | 420 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | timneutkens/next.js fix/remove-unsupported-examples | Change | |
---|---|---|---|
index.html gzip | 568 B | 568 B | ✓ |
link.html gzip | 582 B | 582 B | ✓ |
withRouter.html gzip | 561 B | 561 B | ✓ |
Overall change | 1.71 kB | 1.71 kB | ✓ |
Failing test suitesCommit: 79040ac test/integration/basic/test/index.test.js
Expand output● Basic Features › should polyfill Node.js modules
|
ijjk
approved these changes
Jun 14, 2021
akellbl4
pushed a commit
to akellbl4/next.js
that referenced
this pull request
Jun 14, 2021
Co-authored-by: JJ Kasper <jj@jjsweb.site>
2 tasks
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Jun 16, 2021
Co-authored-by: JJ Kasper <jj@jjsweb.site>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
create-next-app
Related to our CLI tool for quickly starting a new Next.js application.
examples
Issue/PR related to examples
type: next
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zeit/next-css
Bug
fixes #number
Feature
fixes #number
Documentation / Examples