Add lint checking events #26089

ijjk · 2021-06-14T17:57:08Z

Sends events for lint checking similar to type checking

Bug

Related issues linked using fixes #number
Integration tests added

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.

Documentation / Examples

Make sure the linting passes

housseindjirdeh

LGTM, thanks for doing this!

…t-event

ijjk · 2021-06-15T01:01:58Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
buildDuration	11.1s	11s	-82ms
buildDurationCached	2.7s	2.7s	-50ms
nodeModulesSize	46.4 MB	46.4 MB	⚠️ +10.8 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.998	2.038	⚠️ +0.04
/ avg req/sec	1251.03	1226.72	⚠️ -24.31
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.098	1.127	⚠️ +0.03
/error-in-render avg req/sec	2276.2	2218.81	⚠️ -57.39

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	20.2 kB	20.2 kB	✓
webpack-HASH.js gzip	804 B	804 B	✓
Overall change	63 kB	63 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
_app-HASH.js gzip	801 B	801 B	✓
_error-HASH.js gzip	3.17 kB	3.17 kB	✓
amp-HASH.js gzip	527 B	527 B	✓
css-HASH.js gzip	329 B	329 B	✓
hooks-HASH.js gzip	903 B	903 B	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.41 kB	8.41 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
_buildManifest.js gzip	391 B	391 B	✓
Overall change	391 B	391 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
index.html gzip	522 B	522 B	✓
link.html gzip	535 B	535 B	✓
withRouter.html gzip	515 B	515 B	✓
Overall change	1.57 kB	1.57 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
buildDuration	12.5s	12.5s	-31ms
buildDurationCached	3.6s	3.7s	⚠️ +68ms
nodeModulesSize	46.4 MB	46.4 MB	⚠️ +10.8 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	20.2 kB	20.2 kB	✓
webpack-HASH.js gzip	804 B	804 B	✓
Overall change	63 kB	63 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
_app-HASH.js gzip	801 B	801 B	✓
_error-HASH.js gzip	3.17 kB	3.17 kB	✓
amp-HASH.js gzip	527 B	527 B	✓
css-HASH.js gzip	329 B	329 B	✓
hooks-HASH.js gzip	903 B	903 B	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.41 kB	8.41 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
_buildManifest.js gzip	391 B	391 B	✓
Overall change	391 B	391 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
_error.js	16.9 kB	16.9 kB	✓
404.html	1.98 kB	1.98 kB	✓
500.html	1.96 kB	1.96 kB	✓
amp.amp.html	10.8 kB	10.8 kB	✓
amp.html	1.17 kB	1.17 kB	✓
css.html	1.35 kB	1.35 kB	✓
hooks.html	1.23 kB	1.23 kB	✓
index.js	17.2 kB	17.2 kB	⚠️ +2 B
link.js	17.5 kB	17.5 kB	✓
routerDirect.js	17.3 kB	17.3 kB	✓
withRouter.js	17.3 kB	17.3 kB	✓
Overall change	105 kB	105 kB	⚠️ +2 B

Webpack 4 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
buildDuration	9.8s	9.7s	-63ms
buildDurationCached	4s	3.9s	-61ms
nodeModulesSize	46.4 MB	46.4 MB	⚠️ +10.8 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.02	2.009	-0.01
/ avg req/sec	1237.67	1244.36	+6.69
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.127	1.102	-0.02
/error-in-render avg req/sec	2218.58	2267.82	+49.24

Client Bundles (main, webpack, commons)

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
677f882d2ed8..HASH.js gzip	13.4 kB	13.4 kB	✓
framework.HASH.js gzip	41.8 kB	41.8 kB	✓
main-HASH.js gzip	7.99 kB	7.99 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	63.9 kB	63.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
_app-HASH.js gzip	1.07 kB	1.07 kB	✓
_error-HASH.js gzip	3.84 kB	3.84 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	333 B	333 B	✓
hooks-HASH.js gzip	910 B	910 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	295 B	295 B	✓
withRouter-HASH.js gzip	292 B	292 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	9.28 kB	9.28 kB	✓

Client Build Manifests

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
_buildManifest.js gzip	420 B	420 B	✓
Overall change	420 B	420 B	✓

Rendered Page Sizes

	vercel/next.js canary	ijjk/next.js add/lint-event	Change
index.html gzip	568 B	568 B	✓
link.html gzip	580 B	580 B	✓
withRouter.html gzip	561 B	561 B	✓
Overall change	1.71 kB	1.71 kB	✓

Commit: 7150bf7

* Add lint checking events * remove extra log * Update check * Update version check

Add lint checking events

800a341

ijjk added the type: next label Jun 14, 2021

ijjk requested review from housseindjirdeh and timneutkens June 14, 2021 17:57

This comment has been minimized.

Sign in to view

ijjk added 4 commits June 14, 2021 13:30

remove extra log

d7abe52

Merge remote-tracking branch 'upstream/canary' into add/lint-event

1cd4859

Update check

ca5de90

Merge branch 'canary' into add/lint-event

3e3c497

This comment has been minimized.

Sign in to view

ijjk marked this pull request as ready for review June 14, 2021 19:28

ijjk requested review from divmain, lfades and shuding as code owners June 14, 2021 19:28

housseindjirdeh previously approved these changes Jun 14, 2021

View reviewed changes

ijjk added 2 commits June 14, 2021 16:07

Merge remote-tracking branch 'upstream/canary' into add/lint-event

f5a5e81

Merge branch 'add/lint-event' of github.com:ijjk/next.js into add/lin…

08ae81b

…t-event

This comment has been minimized.

Sign in to view

ijjk added 2 commits June 14, 2021 18:20

Update version check

92a9909

Merge remote-tracking branch 'upstream/canary' into add/lint-event

fa53d23

ijjk dismissed housseindjirdeh’s stale review via fa53d23 June 14, 2021 23:21

This comment has been minimized.

Sign in to view

Merge branch 'canary' into add/lint-event

7150bf7

ijjk merged commit 5a78f59 into vercel:canary Jun 15, 2021

ijjk deleted the add/lint-event branch June 15, 2021 01:31

sync-by-unito bot mentioned this pull request Jun 16, 2021

chore(deps): bump next from 10.1.2 to 11.0.0 filecoin-project/slate#793

Closed

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 16, 2021

Add lint checking events (vercel#26089)

d128722

* Add lint checking events * remove extra log * Update check * Update version check

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add lint checking events #26089

Add lint checking events #26089

ijjk commented Jun 14, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

housseindjirdeh left a comment

This comment has been minimized.

This comment has been minimized.

ijjk commented Jun 15, 2021

Add lint checking events #26089

Add lint checking events #26089

Conversation

ijjk commented Jun 14, 2021

Bug

Feature

Documentation / Examples

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

housseindjirdeh left a comment

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

ijjk commented Jun 15, 2021

Stats from current PR