[ESLint] Adds `--quiet` flag, TypeScript resolver and bug fixes #26280

housseindjirdeh · 2021-06-17T19:30:33Z

Feature additions:

Support cli options for lint command #26179: Supports --quiet flag in next lint to only report errors and suppress warnings
eslint-config-next should support absolute imports #25920: Adds eslint-import-resolver-typescript to ESLint config to support absolute TS paths

Bug Fixes:

npx next lint fails #26227. Removes the cacheStrategy option as it's not supported in versions of ESLint < 7.21.0
next-eslint-plugin: aborts when facing a <Link><a/></Link> #26206. Updates link-passhref ESLint rule to support self-enclosed anchor tags

ijjk · 2021-06-17T19:39:52Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
buildDuration	11s	10.9s	-61ms
buildDurationCached	2.7s	2.6s	-58ms
nodeModulesSize	46.4 MB	46.4 MB	⚠️ +620 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.998	2.032	⚠️ +0.03
/ avg req/sec	1251.44	1230.61	⚠️ -20.83
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.135	1.132	0
/error-in-render avg req/sec	2203.46	2208.88	+5.42

Client Bundles (main, webpack, commons)

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	20.2 kB	20.2 kB	✓
webpack-HASH.js gzip	804 B	804 B	✓
Overall change	63 kB	63 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
_app-HASH.js gzip	801 B	801 B	✓
_error-HASH.js gzip	3.17 kB	3.17 kB	✓
amp-HASH.js gzip	527 B	527 B	✓
css-HASH.js gzip	329 B	329 B	✓
hooks-HASH.js gzip	903 B	903 B	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.41 kB	8.41 kB	✓

Client Build Manifests

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
_buildManifest.js gzip	391 B	391 B	✓
Overall change	391 B	391 B	✓

Rendered Page Sizes

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
index.html gzip	524 B	524 B	✓
link.html gzip	536 B	536 B	✓
withRouter.html gzip	516 B	516 B	✓
Overall change	1.58 kB	1.58 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
buildDuration	12.8s	12.4s	-438ms
buildDurationCached	3.7s	3.6s	-134ms
nodeModulesSize	46.4 MB	46.4 MB	⚠️ +620 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
framework-HASH.js gzip	42 kB	42 kB	✓
main-HASH.js gzip	20.2 kB	20.2 kB	✓
webpack-HASH.js gzip	804 B	804 B	✓
Overall change	63 kB	63 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
_app-HASH.js gzip	801 B	801 B	✓
_error-HASH.js gzip	3.17 kB	3.17 kB	✓
amp-HASH.js gzip	527 B	527 B	✓
css-HASH.js gzip	329 B	329 B	✓
hooks-HASH.js gzip	903 B	903 B	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.65 kB	1.65 kB	✓
routerDirect..HASH.js gzip	322 B	322 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	8.41 kB	8.41 kB	✓

Client Build Manifests

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
_buildManifest.js gzip	391 B	391 B	✓
Overall change	391 B	391 B	✓

Serverless bundles Overall decrease ✓

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
_error.js	16.9 kB	16.9 kB	✓
404.html	1.98 kB	1.98 kB	✓
500.html	1.96 kB	1.96 kB	✓
amp.amp.html	10.8 kB	10.8 kB	✓
amp.html	1.17 kB	1.17 kB	✓
css.html	1.35 kB	1.35 kB	✓
hooks.html	1.23 kB	1.23 kB	✓
index.js	17.2 kB	17.2 kB	-2 B
link.js	17.5 kB	17.5 kB	✓
routerDirect.js	17.3 kB	17.3 kB	✓
withRouter.js	17.3 kB	17.3 kB	✓
Overall change	105 kB	105 kB	-2 B

Webpack 4 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
buildDuration	9.7s	9.7s	-5ms
buildDurationCached	4s	3.8s	-155ms
nodeModulesSize	46.4 MB	46.4 MB	⚠️ +620 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.034	2.019	-0.01
/ avg req/sec	1228.93	1238.47	+9.54
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.146	1.133	-0.01
/error-in-render avg req/sec	2182.31	2205.85	+23.54

Client Bundles (main, webpack, commons)

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
677f882d2ed8..HASH.js gzip	13.3 kB	13.3 kB	✓
framework.HASH.js gzip	41.8 kB	41.8 kB	✓
main-HASH.js gzip	7.99 kB	7.99 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	63.8 kB	63.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
_app-HASH.js gzip	1.07 kB	1.07 kB	✓
_error-HASH.js gzip	3.84 kB	3.84 kB	✓
amp-HASH.js gzip	536 B	536 B	✓
css-HASH.js gzip	333 B	333 B	✓
hooks-HASH.js gzip	910 B	910 B	✓
index-HASH.js gzip	227 B	227 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	295 B	295 B	✓
withRouter-HASH.js gzip	292 B	292 B	✓
e025d2764813..52f.css gzip	125 B	125 B	✓
Overall change	9.28 kB	9.28 kB	✓

Client Build Manifests

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
_buildManifest.js gzip	420 B	420 B	✓
Overall change	420 B	420 B	✓

Rendered Page Sizes

	vercel/next.js canary	housseindjirdeh/next.js eslint-update-5	Change
index.html gzip	567 B	567 B	✓
link.html gzip	579 B	579 B	✓
withRouter.html gzip	561 B	561 B	✓
Overall change	1.71 kB	1.71 kB	✓

Commit: 8866553

ijjk · 2021-06-17T20:00:32Z

Failing test suites

Commit: 8866553

test/integration/basic/test/index.test.js

Basic Features > should polyfill Node.js modules

Expand output

● Basic Features › should polyfill Node.js modules

thrown: "Exceeded timeout of 300000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  35 |   afterAll(() => killApp(context.server))
  36 |
> 37 |   it('should polyfill Node.js modules', async () => {
     |   ^
  38 |     const browser = await webdriver(context.appPort, '/node-browser-polyfills')
  39 |
  40 |     console.error({

  at integration/basic/test/index.test.js:37:3
  at Object.<anonymous> (integration/basic/test/index.test.js:18:1)

…el#26280)

housseindjirdeh added 2 commits June 17, 2021 14:55

bug fixes

b5ec567

adds --quiet flag

8866553

housseindjirdeh requested review from divmain, ijjk, lfades, shuding and timneutkens as code owners June 17, 2021 19:30

ijjk added the type: next label Jun 17, 2021

housseindjirdeh added the type: chrome label Jun 17, 2021

housseindjirdeh mentioned this pull request Jun 17, 2021

eslint-config-next should support absolute imports #25920

Closed

timneutkens approved these changes Jun 18, 2021

View reviewed changes

timneutkens merged commit ce4f1e8 into vercel:canary Jun 18, 2021

housseindjirdeh mentioned this pull request Jun 18, 2021

next-eslint-plugin: aborts when facing a <Link><a/></Link> #26206

Closed

Veldrovive mentioned this pull request Jun 19, 2021

Add support for the -f flag for linting styles #26364

Closed

sync-by-unito bot mentioned this pull request Jun 23, 2021

chore(deps): bump next from 10.1.2 to 11.0.1 filecoin-project/slate#799

Closed

flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 24, 2021

[ESLint] Adds --quiet flag, TypeScript resolver and bug fixes (verc…

ee4d4a7

…el#26280)

housseindjirdeh mentioned this pull request Jul 14, 2021

eslint with nextjs 11 not working when following official blog #26265

Closed

vercel locked as resolved and limited conversation to collaborators Jan 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ESLint] Adds `--quiet` flag, TypeScript resolver and bug fixes #26280

[ESLint] Adds `--quiet` flag, TypeScript resolver and bug fixes #26280

housseindjirdeh commented Jun 17, 2021

ijjk commented Jun 17, 2021

ijjk commented Jun 17, 2021

[ESLint] Adds --quiet flag, TypeScript resolver and bug fixes #26280

[ESLint] Adds --quiet flag, TypeScript resolver and bug fixes #26280

Conversation

housseindjirdeh commented Jun 17, 2021

ijjk commented Jun 17, 2021

Stats from current PR

ijjk commented Jun 17, 2021

Failing test suites

[ESLint] Adds `--quiet` flag, TypeScript resolver and bug fixes #26280

[ESLint] Adds `--quiet` flag, TypeScript resolver and bug fixes #26280