Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update create-next-app template favicons #26289

Merged
merged 2 commits into from
Jun 18, 2021
Merged

Update create-next-app template favicons #26289

merged 2 commits into from
Jun 18, 2021

Conversation

pacocoursey
Copy link
Contributor

This updates the favicon from the outdated ZEIT logo to the new Vercel logo in both templates of create-next-app.

Documentation / Examples

  • Make sure the linting passes

@pacocoursey pacocoursey added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Jun 18, 2021
@pacocoursey pacocoursey mentioned this pull request Jun 18, 2021
Merged
4 tasks
@ijjk

This comment has been minimized.

Sign in to view
@pacocoursey pacocoursey marked this pull request as ready for review June 18, 2021 19:09
@ijjk
Copy link
Member

ijjk commented Jun 18, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
buildDuration 11.1s 10.9s -194ms
buildDurationCached 2.6s 2.7s ⚠️ +14ms
nodeModulesSize 49.2 MB 49.2 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.91 1.978 ⚠️ +0.07
/ avg req/sec 1308.75 1263.67 ⚠️ -45.08
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.104 1.108 0
/error-in-render avg req/sec 2263.58 2256.47 ⚠️ -7.11
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 810 B 810 B ✓
Overall change 63 kB 63 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.17 kB 3.17 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 330 B 330 B ✓
hooks-HASH.js gzip 903 B 903 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.41 kB 8.41 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
index.html gzip 523 B 523 B ✓
link.html gzip 532 B 532 B ✓
withRouter.html gzip 514 B 514 B ✓
Overall change 1.57 kB 1.57 kB ✓
Serverless Mode
General
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
buildDuration 12.2s 12.4s ⚠️ +216ms
buildDurationCached 3.7s 3.6s -95ms
nodeModulesSize 49.2 MB 49.2 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
framework-HASH.js gzip 42 kB 42 kB ✓
main-HASH.js gzip 20.2 kB 20.2 kB ✓
webpack-HASH.js gzip 810 B 810 B ✓
Overall change 63 kB 63 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
_app-HASH.js gzip 801 B 801 B ✓
_error-HASH.js gzip 3.17 kB 3.17 kB ✓
amp-HASH.js gzip 527 B 527 B ✓
css-HASH.js gzip 330 B 330 B ✓
hooks-HASH.js gzip 903 B 903 B ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.65 kB 1.65 kB ✓
routerDirect..HASH.js gzip 322 B 322 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 8.41 kB 8.41 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
_buildManifest.js gzip 392 B 392 B ✓
Overall change 392 B 392 B ✓
Serverless bundles
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
_error.js 16.9 kB 16.9 kB -4 B
404.html 1.98 kB 1.98 kB ✓
500.html 1.96 kB 1.96 kB ✓
amp.amp.html 10.8 kB 10.8 kB ✓
amp.html 1.17 kB 1.17 kB ✓
css.html 1.35 kB 1.35 kB ✓
hooks.html 1.23 kB 1.23 kB ✓
index.js 17.2 kB 17.2 kB ⚠️ +4 B
link.js 17.5 kB 17.5 kB ✓
routerDirect.js 17.3 kB 17.3 kB ✓
withRouter.js 17.3 kB 17.3 kB ✓
Overall change 105 kB 105 kB ✓
Webpack 4 Mode (Decrease detected ✓)
General
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
buildDuration 9.7s 10s ⚠️ +263ms
buildDurationCached 3.9s 3.9s ⚠️ +59ms
nodeModulesSize 49.2 MB 49.2 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.018 1.937 -0.08
/ avg req/sec 1238.98 1290.33 +51.35
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.119 1.15 ⚠️ +0.03
/error-in-render avg req/sec 2233.29 2174.19 ⚠️ -59.1
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
677f882d2ed8..HASH.js gzip 13.3 kB 13.3 kB ✓
framework.HASH.js gzip 41.8 kB 41.8 kB ✓
main-HASH.js gzip 7.99 kB 7.99 kB ✓
webpack-HASH.js gzip 757 B 757 B ✓
Overall change 63.8 kB 63.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
_app-HASH.js gzip 1.07 kB 1.07 kB ✓
_error-HASH.js gzip 3.84 kB 3.84 kB ✓
amp-HASH.js gzip 536 B 536 B ✓
css-HASH.js gzip 333 B 333 B ✓
hooks-HASH.js gzip 910 B 910 B ✓
index-HASH.js gzip 227 B 227 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 295 B 295 B ✓
withRouter-HASH.js gzip 292 B 292 B ✓
e025d2764813..52f.css gzip 125 B 125 B ✓
Overall change 9.28 kB 9.28 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
_buildManifest.js gzip 420 B 420 B ✓
Overall change 420 B 420 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js paco/update-cna-favicon Change
index.html gzip 568 B 568 B ✓
link.html gzip 581 B 581 B ✓
withRouter.html gzip 561 B 561 B ✓
Overall change 1.71 kB 1.71 kB ✓
Commit: 8fe07fd

@ijjk ijjk merged commit d0f41f3 into canary Jun 18, 2021
@ijjk ijjk deleted the paco/update-cna-favicon branch June 18, 2021 20:29
flybayer pushed a commit to blitz-js/next.js that referenced this pull request Jun 24, 2021
@pacocoursey
Update create-next-app template favicons (vercel#26289)
84ee9a2
@snyk-bot snyk-bot mentioned this pull request Jul 30, 2021
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@mrmckeb mrmckeb mrmckeb approved these changes

@divmain divmain Awaiting requested review from divmain

@lfades lfades Awaiting requested review from lfades

@shuding shuding Awaiting requested review from shuding

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacocoursey @ijjk @mrmckeb