Update concurrent tests and enable experimental streaming #28892

devknoll · 2021-09-07T17:02:34Z

Updates the React 18 concurrent tests to support streaming, by using webdriver (instead of cheerio) to support dynamic updates, and being more explicit about SSR vs. hydrated content.

Also enables streaming support by setting supportsDynamicHTML: true in pipe(...) for non-bot user agents.

ijjk · 2021-09-07T20:13:45Z

Failing test suites

Commit: 4e3a50e

test/integration/app-document-remove-hmr/test/index.test.js

_app removal HMR > should HMR when _document is removed

Expand output

● _app removal HMR › should HMR when _document is removed

expect(received).toContain(expected) // indexOf

Expected substring: "custom _document"
Received string:    "<head><meta charset=\"utf-8\"><meta name=\"viewport\" content=\"width=device-width\"><meta name=\"next-head-count\" content=\"2\"><noscript data-n-css=\"\"></noscript><script defer=\"\" nomodule=\"\" src=\"/_next/static/chunks/polyfills.js?ts=1631045619445\"></script><script src=\"/_next/static/chunks/webpack.js?ts=1631045619445\" defer=\"\"></script><script src=\"/_next/static/chunks/main.js?ts=1631045619445\" defer=\"\"></script><script src=\"/_next/static/chunks/pages/_app.js?ts=1631045619445\" defer=\"\"></script><script src=\"/_next/static/chunks/pages/index.js?ts=1631045619445\" defer=\"\"></script><script src=\"/_next/static/development/_buildManifest.js?ts=1631045619445\" defer=\"\"></script><script src=\"/_next/static/development/_ssgManifest.js?ts=1631045619445\" defer=\"\"></script><noscript id=\"__next_css__DO_NOT_USE__\"></noscript></head><body><div id=\"__next\"><p>custom _app</p><p>index page updated</p></div><script src=\"/_next/static/chunks/react-refresh.js?ts=1631045619445\"></script><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{}},\"page\":\"/\",\"query\":{},\"buildId\":\"development\",\"nextExport\":true,\"autoExport\":true,\"isFallback\":false,\"scriptLoader\":[]}</script><div id=\"__next-build-watcher\" style=\"position: fixed; bottom: 10px; right: 20px; width: 0px; height: 0px; z-index: 99999;\"></div><next-route-announcer><p aria-live=\"assertive\" id=\"__next-route-announcer__\" role=\"alert\" style=\"border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; width: 1px; white-space: nowrap; overflow-wrap: normal;\"></p></next-route-announcer></body>"

  60 |
  61 |       await check(async () => {
> 62 |         const html = await browser.eval('document.documentElement.innerHTML')
     |                          ^
  63 |         return html.includes('index page updated') &&
  64 |           html.includes('custom _app')
  65 |           ? 'success'

  at Object.<anonymous> (integration/app-document-remove-hmr/test/index.test.js:62:26)

packages/next/server/utils.ts

ijjk · 2021-09-07T22:05:39Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	azukaru/next.js x-update-concurrent-tests-streaming	Change
buildDuration	11.8s	11.6s	-119ms
buildDurationCached	3s	3s	-50ms
nodeModulesSize	48.2 MB	48.2 MB	⚠️ +1.1 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	azukaru/next.js x-update-concurrent-tests-streaming	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.329	2.371	⚠️ +0.04
/ avg req/sec	1073.25	1054.25	⚠️ -19
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.226	1.229	0
/error-in-render avg req/sec	2038.98	2033.67	⚠️ -5.31

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js x-update-concurrent-tests-streaming	Change
745.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	23.3 kB	23.3 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	67.2 kB	67.2 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js x-update-concurrent-tests-streaming	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js x-update-concurrent-tests-streaming	Change
_app-HASH.js gzip	979 B	979 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	329 B	329 B	✓
dynamic-HASH.js gzip	2.67 kB	2.67 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	918 B	918 B	✓
image-HASH.js gzip	4.14 kB	4.14 kB	✓
index-HASH.js gzip	261 B	261 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	318 B	318 B	✓
script-HASH.js gzip	387 B	387 B	✓
withRouter-HASH.js gzip	320 B	320 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	13 kB	13 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js x-update-concurrent-tests-streaming	Change
_buildManifest.js gzip	492 B	492 B	✓
Overall change	492 B	492 B	✓

Rendered Page Sizes

	vercel/next.js canary	azukaru/next.js x-update-concurrent-tests-streaming	Change
index.html gzip	541 B	541 B	✓
link.html gzip	553 B	553 B	✓
withRouter.html gzip	534 B	534 B	✓
Overall change	1.63 kB	1.63 kB	✓

Webpack 4 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	azukaru/next.js x-update-concurrent-tests-streaming	Change
buildDuration	9.5s	9.5s	-16ms
buildDurationCached	4s	3.9s	-44ms
nodeModulesSize	48.2 MB	48.2 MB	⚠️ +1.1 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	azukaru/next.js x-update-concurrent-tests-streaming	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.281	2.328	⚠️ +0.05
/ avg req/sec	1095.91	1073.76	⚠️ -22.15
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.218	1.224	⚠️ +0.01
/error-in-render avg req/sec	2052.15	2041.88	⚠️ -10.27

Client Bundles (main, webpack, commons)

	vercel/next.js canary	azukaru/next.js x-update-concurrent-tests-streaming	Change
16.HASH.js gzip	186 B	186 B	✓
677f882d2ed8..HASH.js gzip	14.1 kB	14.1 kB	✓
framework.HASH.js gzip	41.9 kB	41.9 kB	✓
main-HASH.js gzip	10.7 kB	10.7 kB	✓
webpack-HASH.js gzip	1.19 kB	1.19 kB	✓
Overall change	68.1 kB	68.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	azukaru/next.js x-update-concurrent-tests-streaming	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	azukaru/next.js x-update-concurrent-tests-streaming	Change
_app-HASH.js gzip	964 B	964 B	✓
_error-HASH.js gzip	3.8 kB	3.8 kB	✓
amp-HASH.js gzip	552 B	552 B	✓
css-HASH.js gzip	333 B	333 B	✓
dynamic-HASH.js gzip	2.87 kB	2.87 kB	✓
head-HASH.js gzip	3.06 kB	3.06 kB	✓
hooks-HASH.js gzip	924 B	924 B	✓
index-HASH.js gzip	231 B	231 B	✓
link-HASH.js gzip	1.64 kB	1.64 kB	✓
routerDirect..HASH.js gzip	298 B	298 B	✓
script-HASH.js gzip	3.03 kB	3.03 kB	✓
withRouter-HASH.js gzip	295 B	295 B	✓
30809af5c834..565.css gzip	125 B	125 B	✓
Overall change	18.1 kB	18.1 kB	✓

Client Build Manifests

	vercel/next.js canary	azukaru/next.js x-update-concurrent-tests-streaming	Change
_buildManifest.js gzip	500 B	500 B	✓
Overall change	500 B	500 B	✓

Rendered Page Sizes

	vercel/next.js canary	azukaru/next.js x-update-concurrent-tests-streaming	Change
index.html gzip	585 B	585 B	✓
link.html gzip	596 B	596 B	✓
withRouter.html gzip	577 B	577 B	✓
Overall change	1.76 kB	1.76 kB	✓

Commit: c131136

* canary: v11.1.3-canary.14 Ensure timed out prefetches are cleaned up correctly (vercel#28899) Fix/swc minify (vercel#28898) Update concurrent tests and enable experimental streaming (vercel#28892) Fix Typo in "with-eslint" Example docs (vercel#28601) Examples Prepr CMS update (vercel#28871) fixes with-typescript-graphql: unable to resolve dependency tree (vercel#28637) Update `next/link` API docs to mention a11y and ESLint rule. (vercel#28841) Trim large test output to not exceed limit (vercel#28881) Updates @react-three/drei version and other dependencies. (vercel#28755) Remove unused dependencies (vercel#28876)

ijjk added created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora type: next labels Sep 7, 2021

devknoll force-pushed the x-update-concurrent-tests-streaming branch 2 times, most recently from c99433a to c008c60 Compare September 7, 2021 17:04

Enable streaming and fix concurrent tests

a3f73aa

devknoll force-pushed the x-update-concurrent-tests-streaming branch from c008c60 to a3f73aa Compare September 7, 2021 17:12

This comment has been minimized.

Sign in to view

devknoll marked this pull request as ready for review September 7, 2021 18:42

devknoll requested review from huozhi, ijjk, padmaia, shuding, styfle and timneutkens as code owners September 7, 2021 18:42

Use hardcoded crawler pattern

4e3a50e

devknoll force-pushed the x-update-concurrent-tests-streaming branch from c35a2bc to 4e3a50e Compare September 7, 2021 20:05

This comment has been minimized.

Sign in to view

styfle reviewed Sep 7, 2021

View reviewed changes

packages/next/server/utils.ts Outdated Show resolved Hide resolved

Make case insensitive & a function

29f3ae4

This comment has been minimized.

Sign in to view

Add tests for streaming

c131136

styfle approved these changes Sep 7, 2021

View reviewed changes

kodiakhq bot merged commit 620ca1b into vercel:canary Sep 7, 2021

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update concurrent tests and enable experimental streaming #28892

Update concurrent tests and enable experimental streaming #28892

devknoll commented Sep 7, 2021 •

edited

This comment has been minimized.

ijjk commented Sep 7, 2021

This comment has been minimized.

This comment has been minimized.

ijjk commented Sep 7, 2021

Update concurrent tests and enable experimental streaming #28892

Update concurrent tests and enable experimental streaming #28892

Conversation

devknoll commented Sep 7, 2021 • edited

This comment has been minimized.

ijjk commented Sep 7, 2021

Failing test suites

This comment has been minimized.

This comment has been minimized.

ijjk commented Sep 7, 2021

Stats from current PR

devknoll commented Sep 7, 2021 •

edited