Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/swc minify #28898

Merged
merged 6 commits into from
Sep 7, 2021
Merged

Fix/swc minify #28898

merged 6 commits into from
Sep 7, 2021

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Sep 7, 2021

Uses the new minify function instead of passing an option to the transform function

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Sep 7, 2021
@ijjk
Copy link
Member

ijjk commented Sep 7, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js fix/swc-minify Change
buildDuration 16.4s 16.3s -95ms
buildDurationCached 4.1s 4s -88ms
nodeModulesSize 48.2 MB 48.2 MB ⚠️ +699 B
Page Load Tests Overall increase ✓
vercel/next.js canary padmaia/next.js fix/swc-minify Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.182 3.181 0
/ avg req/sec 785.63 785.99 +0.36
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.024 1.961 -0.06
/error-in-render avg req/sec 1235 1274.93 +39.93
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js fix/swc-minify Change
745.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 23.3 kB 23.3 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 67.2 kB 67.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js fix/swc-minify Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary padmaia/next.js fix/swc-minify Change
_app-HASH.js gzip 979 B 979 B ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 329 B 329 B ✓
dynamic-HASH.js gzip 2.67 kB 2.67 kB ✓
head-HASH.js gzip 351 B 351 B ✓
hooks-HASH.js gzip 918 B 918 B ✓
image-HASH.js gzip 4.14 kB 4.14 kB ✓
index-HASH.js gzip 261 B 261 B ✓
link-HASH.js gzip 1.66 kB 1.66 kB ✓
routerDirect..HASH.js gzip 318 B 318 B ✓
script-HASH.js gzip 387 B 387 B ✓
withRouter-HASH.js gzip 320 B 320 B ✓
bb14e60e810b..30f.css gzip 125 B 125 B ✓
Overall change 13 kB 13 kB ✓
Client Build Manifests
vercel/next.js canary padmaia/next.js fix/swc-minify Change
_buildManifest.js gzip 492 B 492 B ✓
Overall change 492 B 492 B ✓
Rendered Page Sizes
vercel/next.js canary padmaia/next.js fix/swc-minify Change
index.html gzip 541 B 541 B ✓
link.html gzip 553 B 553 B ✓
withRouter.html gzip 534 B 534 B ✓
Overall change 1.63 kB 1.63 kB ✓
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js fix/swc-minify Change
buildDuration 13.1s 13.1s -34ms
buildDurationCached 5.7s 5.4s -308ms
nodeModulesSize 48.2 MB 48.2 MB ⚠️ +699 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js fix/swc-minify Change
/ failed reqs 0 0 ✓
/ total time (seconds) 3.245 3.282 ⚠️ +0.04
/ avg req/sec 770.35 761.84 ⚠️ -8.51
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.961 2.035 ⚠️ +0.07
/error-in-render avg req/sec 1274.6 1228.58 ⚠️ -46.02
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js fix/swc-minify Change
16.HASH.js gzip 186 B 186 B ✓
677f882d2ed8..HASH.js gzip 14.1 kB 14.1 kB ✓
framework.HASH.js gzip 41.9 kB 41.9 kB ✓
main-HASH.js gzip 10.7 kB 10.7 kB ✓
webpack-HASH.js gzip 1.19 kB 1.19 kB ✓
Overall change 68.1 kB 68.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js fix/swc-minify Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary padmaia/next.js fix/swc-minify Change
_app-HASH.js gzip 964 B 964 B ✓
_error-HASH.js gzip 3.8 kB 3.8 kB ✓
amp-HASH.js gzip 552 B 552 B ✓
css-HASH.js gzip 333 B 333 B ✓
dynamic-HASH.js gzip 2.87 kB 2.87 kB ✓
head-HASH.js gzip 3.06 kB 3.06 kB ✓
hooks-HASH.js gzip 924 B 924 B ✓
index-HASH.js gzip 231 B 231 B ✓
link-HASH.js gzip 1.64 kB 1.64 kB ✓
routerDirect..HASH.js gzip 298 B 298 B ✓
script-HASH.js gzip 3.03 kB 3.03 kB ✓
withRouter-HASH.js gzip 295 B 295 B ✓
30809af5c834..565.css gzip 125 B 125 B ✓
Overall change 18.1 kB 18.1 kB ✓
Client Build Manifests
vercel/next.js canary padmaia/next.js fix/swc-minify Change
_buildManifest.js gzip 500 B 500 B ✓
Overall change 500 B 500 B ✓
Rendered Page Sizes
vercel/next.js canary padmaia/next.js fix/swc-minify Change
index.html gzip 585 B 585 B ✓
link.html gzip 596 B 596 B ✓
withRouter.html gzip 577 B 577 B ✓
Overall change 1.76 kB 1.76 kB ✓
Commit: a0b7c1c

@padmaia padmaia merged commit 4f8d883 into vercel:canary Sep 7, 2021
bordeo pushed a commit to filoblu/next.js that referenced this pull request Sep 8, 2021
Merge branch 'canary' into feature/symlink-pages
37c7f1c 
* canary:
  v11.1.3-canary.14
  Ensure timed out prefetches are cleaned up correctly (vercel#28899)
  Fix/swc minify (vercel#28898)
  Update concurrent tests and enable experimental streaming (vercel#28892)
  Fix Typo in "with-eslint" Example docs (vercel#28601)
  Examples Prepr CMS update (vercel#28871)
  fixes with-typescript-graphql: unable to resolve dependency tree (vercel#28637)
  Update `next/link` API docs to mention a11y and ESLint rule. (vercel#28841)
  Trim large test output to not exceed limit (vercel#28881)
  Updates @react-three/drei version and other dependencies. (vercel#28755)
  Remove unused dependencies (vercel#28876)
@padmaia padmaia deleted the fix/swc-minify branch September 15, 2021 17:06
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@ijjk ijjk ijjk approved these changes

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@padmaia @ijjk @styfle