Fix Typo in "with-eslint" Example docs #28601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier it was: ```bash npx create-next-app --example with-eslint with-eslint # or yarn create next-app --example with-eslint with-eslint ``` It was confusing for me, as i couldn't identify which one is *example-name* and which one is *folder-name* (for *with-eslint*). I checked other example folders and was able to digest the stuff. And Hence i modified the cmd it to the below, for better understanding: ```bash npx create-next-app --example with-eslint with-eslint-app # or yarn create next-app --example with-eslint with-eslint-app ```
appsplash99
requested review from
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
leerob
approved these changes
Sep 7, 2021
bordeo
pushed a commit
to filoblu/next.js
that referenced
this pull request
Sep 8, 2021
* canary: v11.1.3-canary.14 Ensure timed out prefetches are cleaned up correctly (vercel#28899) Fix/swc minify (vercel#28898) Update concurrent tests and enable experimental streaming (vercel#28892) Fix Typo in "with-eslint" Example docs (vercel#28601) Examples Prepr CMS update (vercel#28871) fixes with-typescript-graphql: unable to resolve dependency tree (vercel#28637) Update `next/link` API docs to mention a11y and ESLint rule. (vercel#28841) Trim large test output to not exceed limit (vercel#28881) Updates @react-three/drei version and other dependencies. (vercel#28755) Remove unused dependencies (vercel#28876)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier it was:
npx create-next-app --example with-eslint with-eslint # or yarn create next-app --example with-eslint with-eslintIt was confusing for me,
as i couldn't identify which one is example-name and which one is folder-name (for with-eslint).
I checked other example folders and was able to digest the stuff.
But if a new programmer comes who is not familiar with next/npx,
this could have took some time to understand.
And Hence i modified the cmd it to the below, for better understanding:
npx create-next-app --example with-eslint with-eslint-app # or yarn create next-app --example with-eslint with-eslint-appDocumentation / Examples