Add trace file for "next dev" #29633

timneutkens · 2021-10-05T08:51:55Z

Same as the trace file for next build except that this one is rotated the moment 50MB is hit to ensure the file does not grow uncontrollably as next dev is a long-running process in many cases.

Bug

Related issues linked using fixes #number
Integration tests added
Errors have helpful link attached, see contributing.md

Feature

Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
Related issues linked using fixes #number
Integration tests added
Documentation added
Telemetry added. In case of a feature if it's used or not.
Errors have helpful link attached, see contributing.md

Documentation / Examples

Make sure the linting passes

packages/next/trace/report/to-json.ts

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>

ijjk · 2021-10-05T10:18:58Z

Failing test suites

Commit: 80be567

test/integration/gssp-ssr-change-reloading/test/index.test.js

GS(S)P Server-Side Change Reloading > should not reload page when client-side is changed too GSSP
GS(S)P Server-Side Change Reloading > should update page when getServerSideProps is changed only

Expand output

● GS(S)P Server-Side Change Reloading › should not reload page when client-side is changed too GSSP

Failed to replace content.

Pattern: change me

Content: export default function Gssp(props) {
  return (
    <>
      <p id="change">changed</p>
      <p id="props">{JSON.stringify(props)}</p>
    </>
  )
}

export const getServerSideProps = ({ params }) => {
  const count = 2

  return {
    props: {
      count,
      params,
      random: Math.random(),
    },
  }
}

  467 |     } else if (typeof pattern === 'string') {
  468 |       if (!currentContent.includes(pattern)) {
> 469 |         throw new Error(
      |               ^
  470 |           `Failed to replace content.\n\nPattern: ${pattern}\n\nContent: ${currentContent}`
  471 |         )
  472 |       }

  at File.replace (lib/next-test-utils.js:469:15)
  at Object.<anonymous> (integration/gssp-ssr-change-reloading/test/index.test.js:163:63)

● GS(S)P Server-Side Change Reloading › should update page when getServerSideProps is changed only

expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: 2

  185 |       async () =>
  186 |         JSON.parse(await browser.elementByCss('#props').text()).count + '',
> 187 |       '1'
      |          ^
  188 |     )
  189 |   })
  190 | })

  at Object.<anonymous> (integration/gssp-ssr-change-reloading/test/index.test.js:187:10)

test/development/basic/hmr.test.ts

basic HMR > Error Recovery > should recover after exporting an invalid page

Expand output

● basic HMR › Error Recovery › should recover after exporting an invalid page

TIMED OUT: /This is the about page/

  437 |
  438 |   if (hardError) {
> 439 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  440 |   }
  441 |   return false
  442 | }

  at Object.check (lib/next-test-utils.js:439:11)
  at Object.<anonymous> (development/basic/hmr.test.ts:510:9)

● basic HMR › Error Recovery › should recover after exporting an invalid page

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `basic HMR Error Recovery should recover after exporting an invalid page 1`

- Snapshot  - 3
+ Received  + 1

   1 of 1 unhandled error
- Server Error
+ Unhandled Runtime Error

  Error: The default export is not a React Component in page: "/hmr/about5"
-
- This error happened while generating the page. Any console logs will be displayed in the terminal window.

  488 |
  489 |         expect(await hasRedbox(browser)).toBe(true)
> 490 |         expect(await getRedboxHeader(browser)).toMatchInlineSnapshot(`
      |                                                ^
  491 |           " 1 of 1 unhandled error
  492 |           Server Error
  493 |

  at Object.<anonymous> (development/basic/hmr.test.ts:490:48)

ijjk · 2021-10-05T10:18:59Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/trace-file-rotation	Change
buildDuration	17.3s	18.2s	⚠️ +945ms
buildDurationCached	4.2s	4.4s	⚠️ +134ms
nodeModulesSize	183 MB	183 MB	⚠️ +3.08 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add/trace-file-rotation	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.836	4.08	⚠️ +0.24
/ avg req/sec	651.8	612.72	⚠️ -39.08
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.11	2.128	⚠️ +0.02
/error-in-render avg req/sec	1185.09	1174.89	⚠️ -10.2

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/trace-file-rotation	Change
779.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	26.9 kB	26.9 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	70.8 kB	70.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/trace-file-rotation	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/trace-file-rotation	Change
_app-HASH.js gzip	977 B	977 B	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	311 B	311 B	✓
css-HASH.js gzip	328 B	328 B	✓
dynamic-HASH.js gzip	2.67 kB	2.67 kB	✓
head-HASH.js gzip	351 B	351 B	✓
hooks-HASH.js gzip	918 B	918 B	✓
image-HASH.js gzip	4.15 kB	4.15 kB	✓
index-HASH.js gzip	260 B	260 B	✓
link-HASH.js gzip	1.66 kB	1.66 kB	✓
routerDirect..HASH.js gzip	320 B	320 B	✓
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	319 B	319 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	13 kB	13 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/trace-file-rotation	Change
_buildManifest.js gzip	494 B	494 B	✓
Overall change	494 B	494 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/trace-file-rotation	Change
index.html gzip	539 B	539 B	✓
link.html gzip	551 B	551 B	✓
withRouter.html gzip	533 B	533 B	✓
Overall change	1.62 kB	1.62 kB	✓

Default Build with SWC (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/trace-file-rotation	Change
buildDuration	9.2s	9.3s	⚠️ +75ms
buildDurationCached	4.5s	4.4s	-140ms
nodeModulesSize	183 MB	183 MB	⚠️ +3.08 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/trace-file-rotation	Change
/ failed reqs	0	0	✓
/ total time (seconds)	4.114	4.256	⚠️ +0.14
/ avg req/sec	607.72	587.47	⚠️ -20.25
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	2.208	2.158	-0.05
/error-in-render avg req/sec	1132.37	1158.67	+26.3

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/trace-file-rotation	Change
675-HASH.js gzip	13.8 kB	13.8 kB	✓
770.HASH.js gzip	178 B	178 B	✓
framework-HASH.js gzip	50.7 kB	50.7 kB	✓
main-HASH.js gzip	34.9 kB	34.9 kB	✓
webpack-HASH.js gzip	1.64 kB	1.64 kB	✓
Overall change	101 kB	101 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/trace-file-rotation	Change
polyfills-a4..dd70.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/trace-file-rotation	Change
_app-HASH.js gzip	1.33 kB	1.33 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	315 B	315 B	✓
css-HASH.js gzip	331 B	331 B	✓
dynamic-HASH.js gzip	2.79 kB	2.79 kB	✓
head-HASH.js gzip	356 B	356 B	✓
hooks-HASH.js gzip	637 B	637 B	✓
image-HASH.js gzip	573 B	573 B	✓
index-HASH.js gzip	262 B	262 B	✓
link-HASH.js gzip	2.2 kB	2.2 kB	✓
routerDirect..HASH.js gzip	326 B	326 B	✓
script-HASH.js gzip	393 B	393 B	✓
withRouter-HASH.js gzip	322 B	322 B	✓
bb14e60e810b..30f.css gzip	125 B	125 B	✓
Overall change	10.1 kB	10.1 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/trace-file-rotation	Change
_buildManifest.js gzip	511 B	511 B	✓
Overall change	511 B	511 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/trace-file-rotation	Change
index.html gzip	539 B	539 B	✓
link.html gzip	551 B	551 B	✓
withRouter.html gzip	533 B	533 B	✓
Overall change	1.62 kB	1.62 kB	✓

Commit: 80be567

Add trace file for "next dev"

032e599

timneutkens requested review from huozhi, ijjk, padmaia, shuding and styfle as code owners October 5, 2021 08:51

ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Oct 5, 2021

This comment has been minimized.

Sign in to view

sokra requested changes Oct 5, 2021

View reviewed changes

packages/next/trace/report/to-json.ts Show resolved Hide resolved

sokra requested changes Oct 5, 2021

View reviewed changes

packages/next/trace/report/to-json.ts Outdated Show resolved Hide resolved

Update packages/next/trace/report/to-json.ts

80be567

Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>

Fix linting

729ed87

timneutkens merged commit f74ee78 into vercel:canary Oct 5, 2021

timneutkens deleted the add/trace-file-rotation branch October 5, 2021 10:52

ijjk added the hacktoberfest-accepted label Oct 5, 2021

vercel locked as resolved and limited conversation to collaborators Jan 27, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add trace file for "next dev" #29633

Add trace file for "next dev" #29633

timneutkens commented Oct 5, 2021

This comment has been minimized.

This comment has been minimized.

ijjk commented Oct 5, 2021 •

edited

Loading

ijjk commented Oct 5, 2021

Add trace file for "next dev" #29633

Add trace file for "next dev" #29633

Conversation

timneutkens commented Oct 5, 2021

Bug

Feature

Documentation / Examples

This comment has been minimized.

This comment has been minimized.

ijjk commented Oct 5, 2021 • edited Loading

Failing test suites

ijjk commented Oct 5, 2021

Stats from current PR

ijjk commented Oct 5, 2021 •

edited

Loading