Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example): with-typescript-graphql graphql-let package migrate #29996

Merged
merged 3 commits into from
Feb 6, 2022
Merged

fix(example): with-typescript-graphql graphql-let package migrate #29996

merged 3 commits into from
Feb 6, 2022

Conversation

Cheprer
Copy link
Contributor

@Cheprer Cheprer commented Oct 17, 2021

Bug

  • Partially fixes Some examples don't work #25854
  • Badly specified package dependency version (graphql-let). The new major version required manual migration. As specified here.
  • In lib/resolvers.ts
    Module '"*.graphqls"' has no exported member 'MutationResolvers'. Did you mean to use 'import MutationResolvers from "*.graphqls"' instead?ts(2614)

Fixes

  • Migrate as described in migration guide for graphql-let above.
  • Update some npm packages along the way.

…e-0.18.0

# Conflicts:
#	examples/with-typescript-graphql/lib/resolvers.ts
#	examples/with-typescript-graphql/package.json
#	examples/with-typescript-graphql/tsconfig.json
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@kodiakhq kodiakhq bot merged commit bb81f2e into vercel:canary Feb 6, 2022
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
…rcel#29996)

## Bug

- Partially fixes vercel#25854 
- Badly specified package dependency version (`graphql-let`). The new major version required manual migration. As specified [here](https://github.com/piglovesyou/graphql-let/releases/tag/v0.18.0).
- In `lib/resolvers.ts`
```Module '"*.graphqls"' has no exported member 'MutationResolvers'. Did you mean to use 'import MutationResolvers from "*.graphqls"' instead?ts(2614)```


## Fixes

- Migrate as described in migration guide for `graphql-let` above.
- Update some npm packages along the way.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some examples don't work
2 participants