Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added with-react-query example link #30626

Closed
wants to merge 12 commits into from
Closed

added with-react-query example link #30626

wants to merge 12 commits into from

Conversation

jacobra19
Copy link

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added the examples Issue/PR related to examples label Oct 29, 2021
@@ -0,0 +1,3 @@
# React Query example

This example have been moved here: [React Query](https://github.com/tannerlinsley/react-query/tree/master/examples/nextjs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we could have a similar example here, so when you run create-next-app -e with-react-query, it works 😄

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we could have a similar example here, so when you run create-next-app -e with-react-query, it works 😄

Will do, thought an external link will be enough, as I saw on the material-ui example

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @leerob ,
I've updated the the pull request

@balazsorban44
Copy link
Member

Since some of these examples are maintained by their respective authors in their own repositories, we went with the single README approach anyway #38101.

I think we could detect a magical comment in these READMEs and make create-next-app extract the example from the remote location, likely with a prompt for security.

Thanks for the PR anyway!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants