Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run middleware parser handler only for middleware modules #31219

Merged
merged 3 commits into from
Nov 10, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Nov 9, 2021

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Nov 9, 2021
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 9, 2021

Failing test suites

Commit: f54ee5b

test/integration/react-streaming-and-server-components/test/index.test.js

  • concurrentFeatures - dev > should support React.lazy and dynamic imports
Expand output

● concurrentFeatures - dev › should support React.lazy and dynamic imports

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `concurrentFeatures - dev should support React.lazy and dynamic imports 1`

Snapshot: "foo.client"
Received: "loading..."

  161 |   afterAll(async () => {
  162 |     await killApp(context.server)
> 163 |   })
      |     ^
  164 |
  165 |   it('should support React.lazy and dynamic imports', async () => {
  166 |     const html = await renderViaHTTP(context.appPort, '/dynamic-imports')

  at Object.<anonymous> (integration/react-streaming-and-server-components/test/index.test.js:163:25)

@sokra sokra marked this pull request as ready for review November 10, 2021 14:33
@ijjk
Copy link
Member

ijjk commented Nov 10, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bugfix/next-eval-middleware Change
buildDuration 18.5s 18.4s -95ms
buildDurationCached 3.6s 3.6s -73ms
nodeModulesSize 334 MB 334 MB ⚠️ +339 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js bugfix/next-eval-middleware Change
/ failed reqs 0 0
/ total time (seconds) 3.036 3.026 -0.01
/ avg req/sec 823.49 826.24 +2.75
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.453 1.42 -0.03
/error-in-render avg req/sec 1720.17 1761.03 +40.86
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/next-eval-middleware Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/next-eval-middleware Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/next-eval-middleware Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/next-eval-middleware Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/next-eval-middleware Change
index.html gzip 522 B 522 B
link.html gzip 535 B 535 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js bugfix/next-eval-middleware Change
buildDuration 19.8s 20.2s ⚠️ +400ms
buildDurationCached 3.7s 3.7s -51ms
nodeModulesSize 334 MB 334 MB ⚠️ +339 B
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js bugfix/next-eval-middleware Change
/ failed reqs 0 0
/ total time (seconds) 3.056 2.965 -0.09
/ avg req/sec 818.14 843.13 +24.99
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.467 1.465 0
/error-in-render avg req/sec 1704.3 1706.74 +2.44
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js bugfix/next-eval-middleware Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.4 kB 28.4 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.4 kB 72.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bugfix/next-eval-middleware Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js bugfix/next-eval-middleware Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary vercel/next.js bugfix/next-eval-middleware Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js bugfix/next-eval-middleware Change
index.html gzip 522 B 522 B
link.html gzip 534 B 534 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB
Commit: 4809737

@styfle styfle linked an issue Nov 10, 2021 that may be closed by this pull request
@kodiakhq kodiakhq bot merged commit 9c4c712 into canary Nov 10, 2021
@kodiakhq kodiakhq bot deleted the bugfix/next-eval-middleware branch November 10, 2021 15:31
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regression]: __next_eval__ is not defined with next dev
3 participants