Base Http for BaseServer #32999

karaggeorge · 2022-01-04T20:35:37Z

Adds base http classes, along with Node + Web (partial) implementations
Removes usage of IncomingMessage and ServerResponse from base server

packages/next/server/base-server.ts

packages/next/server/image-optimizer.ts

packages/next/server/render.tsx

ijjk · 2022-01-06T15:17:06Z

Failing test suites

Commit: 80ea9ea

test/integration/typescript/test/index.test.js

TypeScript Features > default behavior > should render the cookies page

Expand output

● TypeScript Features › default behavior › should render the cookies page

expect(received).toBe(expected) // Object.is equality

Expected: "{}"
Received: ""

  39 |     afterAll(() => killApp(app))
  40 |
> 41 |     it('should render the page', async () => {
     |                                          ^
  42 |       const $ = await get$('/hello')
  43 |       expect($('body').text()).toMatch(/Hello World/)
  44 |       expect($('body').text()).toMatch(/1000000000000/)

  at Object.<anonymous> (integration/typescript/test/index.test.js:41:42)

shuding · 2022-01-11T20:22:05Z

packages/next/server/base-http.ts

+  }
+}
+
+export class WebNextRequest extends BaseNextRequest<ReadableStream | null> {


(Not blocking) maybe we can separate Web and Node request/response in 2 files just like we did for base-server and web-server.

packages/next/server/base-http.ts

packages/next/build/webpack/loaders/next-serverless-loader/api-handler.ts

packages/next/server/base-server.ts

packages/next/server/base-http.ts

packages/next/server/base-server.ts

shuding · 2022-01-11T20:49:48Z

Great work, there are a lot of changes and I can still see as any and some remaining modules with the old interfaces that we can probably refactor later.

ijjk · 2022-01-14T20:52:00Z

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	karaggeorge/next.js base-http	Change
buildDuration	15.9s	16.8s	⚠️ +938ms
buildDurationCached	3.4s	3.5s	⚠️ +113ms
nodeModulesSize	355 MB	355 MB	⚠️ +29.7 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	karaggeorge/next.js base-http	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.227	3.401	⚠️ +0.17
/ avg req/sec	774.82	735.03	⚠️ -39.79
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.442	1.55	⚠️ +0.11
/error-in-render avg req/sec	1733.19	1612.86	⚠️ -120.33

Client Bundles (main, webpack, commons)

	vercel/next.js canary	karaggeorge/next.js base-http	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	27.2 kB	27.2 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71 kB	71 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	karaggeorge/next.js base-http	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	karaggeorge/next.js base-http	Change
_app-HASH.js gzip	1.37 kB	1.37 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	326 B	326 B	✓
dynamic-HASH.js gzip	2.37 kB	2.37 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	919 B	919 B	✓
image-HASH.js gzip	4.7 kB	4.7 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	2.13 kB	2.13 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	karaggeorge/next.js base-http	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	karaggeorge/next.js base-http	Change
index.html gzip	531 B	531 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Default Build with SWC (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	karaggeorge/next.js base-http	Change
buildDuration	17.6s	17.6s	-65ms
buildDurationCached	3.4s	3.6s	⚠️ +212ms
nodeModulesSize	355 MB	355 MB	⚠️ +29.7 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	karaggeorge/next.js base-http	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.195	3.373	⚠️ +0.18
/ avg req/sec	782.49	741.22	⚠️ -41.27
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.408	1.555	⚠️ +0.15
/error-in-render avg req/sec	1775.53	1607.49	⚠️ -168.04

Client Bundles (main, webpack, commons)

	vercel/next.js canary	karaggeorge/next.js base-http	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	27.3 kB	27.3 kB	✓
webpack-HASH.js gzip	1.44 kB	1.44 kB	✓
Overall change	71.3 kB	71.3 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	karaggeorge/next.js base-http	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	karaggeorge/next.js base-http	Change
_app-HASH.js gzip	1.35 kB	1.35 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.36 kB	2.36 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	911 B	911 B	✓
image-HASH.js gzip	4.73 kB	4.73 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	2.19 kB	2.19 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	14.1 kB	14.1 kB	✓

Client Build Manifests

	vercel/next.js canary	karaggeorge/next.js base-http	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	karaggeorge/next.js base-http	Change
index.html gzip	531 B	531 B	✓
link.html gzip	545 B	545 B	✓
withRouter.html gzip	526 B	526 B	✓
Overall change	1.6 kB	1.6 kB	✓

Commit: 7616f52

…erver (#4467) In vercel/next.js#32999 (released as part of 12.0.9), Next.js made an internal change, so that it now wraps the raw `http.IncomingMessage` and `http.ServerResponse` objects which get passed to the main server request handler in `NodeNextRequest` and `NodeNextResponse` objects, respectively. We therefore need to unwrap them before we can use them. This does that unwrapping (if necessary; older versions of nextjs still don't need it) and fixes the relevant types. Fixes #4463 Fixes vercel/next.js#33726

karaggeorge added 4 commits December 8, 2021 13:26

Initial abstract classes

25712c2

WIP

0be075c

Merge branch 'canary' into base-req-res

1e015b0

Remove Node http classes from base server

74c3a7f

karaggeorge requested review from huozhi, ijjk, padmaia, shuding, styfle and timneutkens as code owners January 4, 2022 20:35

ijjk added the type: next label Jan 4, 2022

This was referenced Jan 4, 2022

Initial abstract classes #32298

Closed

Switchable server runtime #31506

Closed

karaggeorge commented Jan 4, 2022

View reviewed changes

packages/next/server/base-server.ts Show resolved Hide resolved

This comment has been minimized.

Sign in to view

Fix request meta accessors

b001269

This comment has been minimized.

Sign in to view

karaggeorge added 2 commits January 5, 2022 21:40

Fix handler parameters

95f7e00

Remove unused imports

7fbff58

This comment has been minimized.

Sign in to view

Fix serverless handlers

6525de6

This comment has been minimized.

Sign in to view

Fix preview data

80ea9ea

This comment has been minimized.

Sign in to view

styfle reviewed Jan 6, 2022

View reviewed changes

packages/next/server/image-optimizer.ts Outdated Show resolved Hide resolved

styfle reviewed Jan 6, 2022

View reviewed changes

packages/next/server/render.tsx Outdated Show resolved Hide resolved

karaggeorge added 2 commits January 6, 2022 19:01

Fix cookies missing in Node req and remove comment

8a5ba9d

Merge branch 'canary' into base-http

e9b478a

This comment has been minimized.

Sign in to view

Merge branch 'canary' into base-http

4d8fbdb

This comment has been minimized.

Sign in to view

Merge branch 'canary' into base-http

01761c7

This comment has been minimized.

Sign in to view

shuding reviewed Jan 11, 2022

View reviewed changes

shuding added 3 commits January 14, 2022 21:19

merge canary and resolve conflicts

5a98664

small fixes

7ee6e3f

rename .req and .res for node http interfaces

7616f52

shuding approved these changes Jan 14, 2022

View reviewed changes

kodiakhq bot merged commit 3e00a81 into vercel:canary Jan 14, 2022

tmkx mentioned this pull request Jan 21, 2022

Add missing typings #33181

Closed

10 tasks

lobsterkatie mentioned this pull request Jan 28, 2022

fix(nextjs): Unwrap req and res if necessary when instrumenting server getsentry/sentry-javascript#4467

Merged

vercel locked as resolved and limited conversation to collaborators Feb 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Base Http for BaseServer #32999

Base Http for BaseServer #32999

karaggeorge commented Jan 4, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Jan 6, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

shuding Jan 11, 2022

shuding commented Jan 11, 2022

ijjk commented Jan 14, 2022

Base Http for BaseServer #32999

Base Http for BaseServer #32999

Conversation

karaggeorge commented Jan 4, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Jan 6, 2022

Failing test suites

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

shuding Jan 11, 2022

Choose a reason for hiding this comment

shuding commented Jan 11, 2022

ijjk commented Jan 14, 2022

Stats from current PR