Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base Http for BaseServer #32999

Merged
merged 16 commits into from Jan 14, 2022
Merged

Base Http for BaseServer #32999

merged 16 commits into from Jan 14, 2022

Conversation

karaggeorge
Copy link
Contributor

@karaggeorge karaggeorge commented Jan 4, 2022

Adds base http classes, along with Node + Web (partial) implementations
Removes usage of IncomingMessage and ServerResponse from base server

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

packages/next/server/render.tsx Outdated Show resolved Hide resolved
@ijjk
Copy link
Member

ijjk commented Jan 6, 2022

Failing test suites

Commit: 80ea9ea

test/integration/typescript/test/index.test.js

  • TypeScript Features > default behavior > should render the cookies page
Expand output

● TypeScript Features › default behavior › should render the cookies page

expect(received).toBe(expected) // Object.is equality

Expected: "{}"
Received: ""

  39 |     afterAll(() => killApp(app))
  40 |
> 41 |     it('should render the page', async () => {
     |                                          ^
  42 |       const $ = await get$('/hello')
  43 |       expect($('body').text()).toMatch(/Hello World/)
  44 |       expect($('body').text()).toMatch(/1000000000000/)

  at Object.<anonymous> (integration/typescript/test/index.test.js:41:42)

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

}
}

export class WebNextRequest extends BaseNextRequest<ReadableStream | null> {
Copy link
Member

@shuding shuding Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Not blocking) maybe we can separate Web and Node request/response in 2 files just like we did for base-server and web-server.

packages/next/server/base-http.ts Outdated Show resolved Hide resolved
packages/next/server/base-server.ts Show resolved Hide resolved
packages/next/server/base-http.ts Outdated Show resolved Hide resolved
packages/next/server/base-server.ts Show resolved Hide resolved
@shuding
Copy link
Member

shuding commented Jan 11, 2022

Great work, there are a lot of changes and I can still see as any and some remaining modules with the old interfaces that we can probably refactor later.

@ijjk
Copy link
Member

ijjk commented Jan 14, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary karaggeorge/next.js base-http Change
buildDuration 15.9s 16.8s ⚠️ +938ms
buildDurationCached 3.4s 3.5s ⚠️ +113ms
nodeModulesSize 355 MB 355 MB ⚠️ +29.7 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary karaggeorge/next.js base-http Change
/ failed reqs 0 0
/ total time (seconds) 3.227 3.401 ⚠️ +0.17
/ avg req/sec 774.82 735.03 ⚠️ -39.79
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.442 1.55 ⚠️ +0.11
/error-in-render avg req/sec 1733.19 1612.86 ⚠️ -120.33
Client Bundles (main, webpack, commons)
vercel/next.js canary karaggeorge/next.js base-http Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary karaggeorge/next.js base-http Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary karaggeorge/next.js base-http Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.7 kB 4.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary karaggeorge/next.js base-http Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary karaggeorge/next.js base-http Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary karaggeorge/next.js base-http Change
buildDuration 17.6s 17.6s -65ms
buildDurationCached 3.4s 3.6s ⚠️ +212ms
nodeModulesSize 355 MB 355 MB ⚠️ +29.7 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary karaggeorge/next.js base-http Change
/ failed reqs 0 0
/ total time (seconds) 3.195 3.373 ⚠️ +0.18
/ avg req/sec 782.49 741.22 ⚠️ -41.27
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.408 1.555 ⚠️ +0.15
/error-in-render avg req/sec 1775.53 1607.49 ⚠️ -168.04
Client Bundles (main, webpack, commons)
vercel/next.js canary karaggeorge/next.js base-http Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary karaggeorge/next.js base-http Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary karaggeorge/next.js base-http Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.73 kB 4.73 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.1 kB 14.1 kB
Client Build Manifests
vercel/next.js canary karaggeorge/next.js base-http Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary karaggeorge/next.js base-http Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: 7616f52

@kodiakhq kodiakhq bot merged commit 3e00a81 into vercel:canary Jan 14, 2022
40 of 42 checks passed
@tmkx tmkx mentioned this pull request Jan 21, 2022
10 tasks
lobsterkatie added a commit to getsentry/sentry-javascript that referenced this issue Jan 28, 2022
…erver (#4467)

In vercel/next.js#32999 (released as part of 12.0.9), Next.js made an internal change, so that it now wraps the raw `http.IncomingMessage` and `http.ServerResponse` objects which get passed to the main server request handler in `NodeNextRequest` and `NodeNextResponse` objects, respectively. We therefore need to unwrap them before we can use them.

This does that unwrapping (if necessary; older versions of nextjs still don't need it) and fixes the relevant types.

Fixes #4463
Fixes vercel/next.js#33726
@vercel vercel locked as resolved and limited conversation to collaborators Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants