fix(next-swc): Update swc #33427
Merged
fix(next-swc): Update swc #33427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
kdy1
requested review from
huozhi,
ijjk,
shuding and
timneutkens
as code owners
Stats from current PRDefault Build (Increase detected
|
| vercel/next.js canary | kdy1/next.js swc-up-4 | Change | |
|---|---|---|---|
| buildDuration | 13.5s | 13.4s | -133ms |
| buildDurationCached | 3s | 3s | |
| nodeModulesSize | 354 MB | 354 MB | -8 B |
Page Load Tests Overall increase ✓
| vercel/next.js canary | kdy1/next.js swc-up-4 | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.715 | 2.702 | -0.01 |
| / avg req/sec | 920.97 | 925.38 | +4.41 |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.147 | 1.121 | -0.03 |
| /error-in-render avg req/sec | 2179.42 | 2230.95 | +51.53 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | kdy1/next.js swc-up-4 | Change | |
|---|---|---|---|
| 450.HASH.js gzip | 179 B | 179 B | ✓ |
| framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
| main-HASH.js gzip | 27.2 kB | 27.2 kB | ✓ |
| webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
| Overall change | 71 kB | 71 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | kdy1/next.js swc-up-4 | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | kdy1/next.js swc-up-4 | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.37 kB | 1.37 kB | ✓ |
| _error-HASH.js gzip | 194 B | 194 B | ✓ |
| amp-HASH.js gzip | 312 B | 312 B | ✓ |
| css-HASH.js gzip | 326 B | 326 B | ✓ |
| dynamic-HASH.js gzip | 2.37 kB | 2.37 kB | ✓ |
| head-HASH.js gzip | 350 B | 350 B | ✓ |
| hooks-HASH.js gzip | 919 B | 919 B | ✓ |
| image-HASH.js gzip | 4.7 kB | 4.7 kB | ✓ |
| index-HASH.js gzip | 263 B | 263 B | ✓ |
| link-HASH.js gzip | 2.13 kB | 2.13 kB | ✓ |
| routerDirect..HASH.js gzip | 321 B | 321 B | ✓ |
| script-HASH.js gzip | 383 B | 383 B | ✓ |
| withRouter-HASH.js gzip | 318 B | 318 B | ✓ |
| 85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
| Overall change | 14.1 kB | 14.1 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | kdy1/next.js swc-up-4 | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 459 B | 459 B | ✓ |
| Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | kdy1/next.js swc-up-4 | Change | |
|---|---|---|---|
| index.html gzip | 531 B | 531 B | ✓ |
| link.html gzip | 546 B | 546 B | ✓ |
| withRouter.html gzip | 527 B | 527 B | ✓ |
| Overall change | 1.6 kB | 1.6 kB | ✓ |
Default Build with SWC (Increase detected ⚠️ )
General Overall decrease ✓
| vercel/next.js canary | kdy1/next.js swc-up-4 | Change | |
|---|---|---|---|
| buildDuration | 16.3s | 16.2s | -96ms |
| buildDurationCached | 3.1s | 3.1s | |
| nodeModulesSize | 354 MB | 354 MB | -8 B |
Page Load Tests Overall increase ✓
| vercel/next.js canary | kdy1/next.js swc-up-4 | Change | |
|---|---|---|---|
| / failed reqs | 0 | 0 | ✓ |
| / total time (seconds) | 2.718 | 2.724 | |
| / avg req/sec | 919.64 | 917.91 | |
| /error-in-render failed reqs | 0 | 0 | ✓ |
| /error-in-render total time (seconds) | 1.14 | 1.118 | -0.02 |
| /error-in-render avg req/sec | 2193.89 | 2236.73 | +42.84 |
Client Bundles (main, webpack, commons)
| vercel/next.js canary | kdy1/next.js swc-up-4 | Change | |
|---|---|---|---|
| 450.HASH.js gzip | 179 B | 179 B | ✓ |
| framework-HASH.js gzip | 42.3 kB | 42.3 kB | ✓ |
| main-HASH.js gzip | 27.3 kB | 27.3 kB | ✓ |
| webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
| Overall change | 71.3 kB | 71.3 kB | ✓ |
Legacy Client Bundles (polyfills)
| vercel/next.js canary | kdy1/next.js swc-up-4 | Change | |
|---|---|---|---|
| polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
| Overall change | 31 kB | 31 kB | ✓ |
Client Pages
| vercel/next.js canary | kdy1/next.js swc-up-4 | Change | |
|---|---|---|---|
| _app-HASH.js gzip | 1.35 kB | 1.35 kB | ✓ |
| _error-HASH.js gzip | 180 B | 180 B | ✓ |
| amp-HASH.js gzip | 305 B | 305 B | ✓ |
| css-HASH.js gzip | 321 B | 321 B | ✓ |
| dynamic-HASH.js gzip | 2.36 kB | 2.36 kB | ✓ |
| head-HASH.js gzip | 342 B | 342 B | ✓ |
| hooks-HASH.js gzip | 911 B | 911 B | ✓ |
| image-HASH.js gzip | 4.73 kB | 4.73 kB | ✓ |
| index-HASH.js gzip | 256 B | 256 B | ✓ |
| link-HASH.js gzip | 2.19 kB | 2.19 kB | ✓ |
| routerDirect..HASH.js gzip | 314 B | 314 B | ✓ |
| script-HASH.js gzip | 375 B | 375 B | ✓ |
| withRouter-HASH.js gzip | 309 B | 309 B | ✓ |
| 85e02e95b279..7e3.css gzip | 107 B | 107 B | ✓ |
| Overall change | 14.1 kB | 14.1 kB | ✓ |
Client Build Manifests
| vercel/next.js canary | kdy1/next.js swc-up-4 | Change | |
|---|---|---|---|
| _buildManifest.js gzip | 459 B | 459 B | ✓ |
| Overall change | 459 B | 459 B | ✓ |
Rendered Page Sizes
| vercel/next.js canary | kdy1/next.js swc-up-4 | Change | |
|---|---|---|---|
| index.html gzip | 532 B | 532 B | ✓ |
| link.html gzip | 545 B | 545 B | ✓ |
| withRouter.html gzip | 526 B | 526 B | ✓ |
| Overall change | 1.6 kB | 1.6 kB | ✓ |
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
This PR applies lots of patches, including - swc-project/swc#3303 - swc-project/swc#3301 - swc-project/swc#3287 - swc-project/swc#3286 - swc-project/swc#3289 - swc-project/swc#3302 - Fixes vercel#33265 (Verified) I'll undraft this after verifying
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies lots of patches, including
feat(es/minifier): Drop more nodes from parallel optimizer swc-project/swc#3303
fix(es/minifier): Remove more side-effect-free expressions. swc-project/swc#3301
fix(es/minifier): Inline into interpolations in tagged template literals swc-project/swc#3287
fix(es/minifier): Fix analysis of unary expressions swc-project/swc#3286
fix(es/resolver): Ignore names of jsx attributes swc-project/swc#3289
fix(es/minifier): Don't emit invalid code swc-project/swc#3302
(Verified)
I'll undraft this after verifying