Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rsc export component name detection #33608

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Jan 24, 2022

Bug

Related to #33604 when using an anonymous function export, rsc loader parsing will fail

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk

This comment has been minimized.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 24, 2022
@ijjk
Copy link
Member

ijjk commented Jan 24, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix-export-detect Change
buildDuration 14.4s 14.2s -191ms
buildDurationCached 3.8s 3.7s -67ms
nodeModulesSize 355 MB 355 MB ⚠️ +447 B
Page Load Tests Overall increase ✓
vercel/next.js canary huozhi/next.js fix-export-detect Change
/ failed reqs 0 0
/ total time (seconds) 3.384 3.306 -0.08
/ avg req/sec 738.72 756.22 +17.5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.496 1.503 ⚠️ +0.01
/error-in-render avg req/sec 1670.7 1662.96 ⚠️ -7.74
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix-export-detect Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 27.2 kB 27.2 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71 kB 71 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix-export-detect Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix-export-detect Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 326 B 326 B
dynamic-HASH.js gzip 2.37 kB 2.37 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 919 B 919 B
image-HASH.js gzip 4.87 kB 4.87 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.13 kB 2.13 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.2 kB 14.2 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix-export-detect Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix-export-detect Change
index.html gzip 530 B 530 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix-export-detect Change
buildDuration 17.9s 18.1s ⚠️ +207ms
buildDurationCached 3.7s 3.7s -17ms
nodeModulesSize 355 MB 355 MB ⚠️ +447 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix-export-detect Change
/ failed reqs 0 0
/ total time (seconds) 3.354 3.4 ⚠️ +0.05
/ avg req/sec 745.44 735.34 ⚠️ -10.1
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.502 1.515 ⚠️ +0.01
/error-in-render avg req/sec 1664.74 1649.77 ⚠️ -14.97
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix-export-detect Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 27.3 kB 27.3 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 71.3 kB 71.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix-export-detect Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix-export-detect Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.36 kB 2.36 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 911 B 911 B
image-HASH.js gzip 4.89 kB 4.89 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.19 kB 2.19 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 14.2 kB 14.2 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix-export-detect Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix-export-detect Change
index.html gzip 531 B 531 B
link.html gzip 544 B 544 B
withRouter.html gzip 525 B 525 B
Overall change 1.6 kB 1.6 kB
Commit: e4e8a90

@huozhi huozhi merged commit 62b6309 into vercel:canary Jan 24, 2022
@huozhi huozhi deleted the fix-export-detect branch January 24, 2022 16:20
natew pushed a commit to natew/next.js that referenced this pull request Feb 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants