Dynamic imports with named exports #3590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrudviGali
changed the title
khrome83
suggested changes
Feb 20, 2018
arunoda
suggested changes
Mar 31, 2018
| @@ -31,7 +31,7 @@ export default function dynamicComponent (p, o) { | |||
|
|
|||
| this.LoadingComponent = options.loading ? options.loading : () => (<p>loading...</p>) | |||
| this.ssr = options.ssr === false ? options.ssr : true | |||
|
|
|||
| this.compName = options.component ? options.component : undefined | |||
There was a problem hiding this comment.
We don't need this expression. Use options.componentName instead. It's clear and does the job.
| @@ -55,7 +55,7 @@ export default function dynamicComponent (p, o) { | |||
|
|
|||
| loadComponent () { | |||
| promise.then((m) => { | |||
| const AsyncComponent = m.default || m | |||
| const AsyncComponent = this.compName ? m[this.compName] : m.default | |||
There was a problem hiding this comment.
Add the m.default || m part as well.
|
Extracting exports based on string keys is non-standard and impossible to type with TS/Flow (which hints at a bad pattern IMHO). Making standard Related #2940 |
|
@herrstucki is actually right, it should be like |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a feature allowing dynamic imports to import specific components not just default ones from the module.
The current code only allows default exports to be imported to the outer world.
Usage should look like:
dynamic(import('./moduleName'), { component: 'ComponentName', });By this, it will import only 'ComponentName' from the module. It will be useful for structures which are having multiple exports from a single file.