Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove workspace from package.json since we have `pnpm-works… #38166

Merged
merged 1 commit into from
Jul 6, 2022
Merged

chore: remove workspace from package.json since we have `pnpm-works… #38166

merged 1 commit into from
Jul 6, 2022

Conversation

dammy001
Copy link
Contributor

…pace`

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@balazsorban44 balazsorban44 merged commit a37abc6 into vercel:canary Jul 6, 2022
@styfle styfle mentioned this pull request Jul 6, 2022
Merged
styfle added a commit that referenced this pull request Jul 6, 2022
@styfle
Revert "chore: remove workspace from package.json since we have `pn…
d2e226d 
…pm-works… (#38166)"

This reverts commit a37abc6.
balazsorban44 pushed a commit that referenced this pull request Jul 6, 2022
@styfle
Revert "chore: remove workspace from package.json since we have `pn…
fb86860 
…pm-works…" (#38376)

Revert "chore: remove workspace from `package.json` since we have `pnpm-works… (#38166)"

This reverts commit a37abc6.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dammy001 @balazsorban44