Fix #3900 return 404 on asset hash mismatch in prod #3941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunoda
suggested changes
Mar 6, 2018
server/index.js
Outdated
| @@ -467,7 +467,11 @@ export default class Server { | |||
| } | |||
|
|
|||
| if (hash !== this.buildStats[filename].hash) { | |||
| throw new Error(`Invalid Build File Hash(${hash}) for chunk: ${filename}`) | |||
There was a problem hiding this comment.
Here's console.log the ^^ message and do return this.send404(res).
In the dev mode, there's no buildId and it's been handled in few lines before.
|
Thanks @arunoda It looks like #3793 changed how this is handled pretty significantly: https://github.com/zeit/next.js/blob/canary/server/index.js#L177 I tweaked |
|
I'd like to +1 this, is there something that still needs to be improved to get this released? |
timneutkens
approved these changes
Mar 31, 2018
|
Thanks guys, any estimate on when could this be released on npm? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #3900 I'm looking to have Next.js respond with a 404 when someone requests a hash from an asset that doesn't exist in production instead of what it currently does which is 500 Internal server error.
Currently,
handleBuildHashinserver/index.jsthrows an error regardless of environment, so I'm looking at tweaking it to send a 404 in production.Example:
200 -> https://custom-server-koa-wxksegmzhf.now.sh/_next/7c048a193f99703d6180e88866b6e06b/app.js
500 Internal server error -> https://custom-server-koa-wxksegmzhf.now.sh/_next/OLD_HASH_VALUE/app.js
Thanks for your time!