Add Router method to execute custom logic before popstate events #3956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gcpantazis I'm okay to take this feature this in. But not as a solution to #2682 |
arunoda
reviewed
Mar 14, 2018
lib/router/router.js
Outdated
| @@ -51,6 +52,12 @@ export default class Router { | |||
| } | |||
|
|
|||
| async onPopState (e) { | |||
| // If the downstream application returns falsy, return. | |||
| // They will then be responsible for handling the event. | |||
| if (!this._beforePopState(e.state)) { | |||
There was a problem hiding this comment.
Could you move this after the following if condition?
|
Thanks @arunoda + @timneutkens. I did check |
timneutkens
approved these changes
Mar 31, 2018
|
Going to merge this in, can't think of a different way to solve this, maybe we'll change it in the future. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4008,
popstateallows the Router to client-render pages that should be blocked byuseFileSystemPublicRoutes: false. See comment here.This commit adds a pre-hook into
Router's response topopstate, which allows the downstream user to inject their own functionality / cancel Router's response if they'd like to handle it themselves. See README update for docs.Example usage: https://github.com/gcpantazis/nextjs-playground/tree/uFSPR-solutionA
cc/ @timneutkens