Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add precision about pageExtensions #40016

Merged
merged 4 commits into from
Aug 28, 2022
Merged

Conversation

yoannmoinet
Copy link
Contributor

Adding a precision because when you change the pageExtensions configuration in next.config.js, middleware.ts isn't recognized anymore.

Took me some time to debug this one, not sure if it should be considered a bug or just lack of documentation.
I'll let you be the judge of that.

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I'm not sure we need to document this here as we already explain this under the pageExtensions doc here https://nextjs.org/docs/api-reference/next.config.js/custom-page-extensions

@yoannmoinet
Copy link
Contributor Author

@ijjk ah! I totally missed it.

I added the middleware way after I touched pageExtensions though, so I didn't go back to the pageExtensions doc when I had an issue with the middleware.

I'm fine closing this, it's just that I figured, if it happened to me, might happen to others.
Feel free to close this.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to add this note, updated to link to the existing pageExtensions doc. Thanks!

@kodiakhq kodiakhq bot merged commit 1b61d1f into vercel:canary Aug 28, 2022
leerob added a commit that referenced this pull request Aug 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants