-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade react hot loader #4171
Merged
Merged
Upgrade react hot loader #4171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everettss
approved these changes
Apr 21, 2018
Everettss
approved these changes
Apr 21, 2018
The latest version is now v4.1.1, there were some fixes. |
…-4-1 # Conflicts: # package.json # yarn.lock
…into fix/upgrade-rhl-4-1 # Conflicts: # package.json
leo
approved these changes
Apr 22, 2018
This was meant to be published in v6.0.0-canary.5, and I can't work out why, but the |
We will try to upgrade to v6.0.0-canary.5 from v5 to get ride of all the warnings in the console. But that will be challenging. Not all the babel ecosystem is ready for @babel v7.0.0-beta. |
lependu
pushed a commit
to lependu/next.js
that referenced
this pull request
Jun 19, 2018
* Upgrade react hot loader * Upgrade to 4.1.1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades React hot loader to the React 16.3 compatible version
Since they removed componentWillReceiveProps we might have to test some older version.