Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react hot loader #4171

Merged
merged 5 commits into from
Apr 22, 2018
Merged

Conversation

timneutkens
Copy link
Member

Upgrades React hot loader to the React 16.3 compatible version

Since they removed componentWillReceiveProps we might have to test some older version.

@jaydenseric
Copy link
Contributor

The latest version is now v4.1.1, there were some fixes.

@leo leo self-requested a review April 22, 2018 22:53
@timneutkens timneutkens merged commit bc03c59 into vercel:canary Apr 22, 2018
@timneutkens timneutkens deleted the fix/upgrade-rhl-4-1 branch April 22, 2018 23:11
@jaydenseric
Copy link
Contributor

This was meant to be published in v6.0.0-canary.5, and I can't work out why, but the react-hot-loader dependency is still v4.0.1 in the published package.json.

@oliviertassinari
Copy link
Contributor

We will try to upgrade to v6.0.0-canary.5 from v5 to get ride of all the warnings in the console. But that will be challenging. Not all the babel ecosystem is ready for @babel v7.0.0-beta.

lependu pushed a commit to lependu/next.js that referenced this pull request Jun 19, 2018
* Upgrade react hot loader

* Upgrade to 4.1.1
@lock lock bot locked as resolved and limited conversation to collaborators Apr 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants