Disable smooth scroll in navigation attempts #43529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable smooth scroll in navigation attempts, restore scroll behaviour when the navigation completes. The current implementation seems to be wrong, as the scroll behaviour "auto" immediately or during scrolling switches back to "smooth" or the globally defined behaviour of the html tag. Local experiments showed that the scrolling behaviour "auto" must be initiated at the start of a route change "routeChangeStart" and must be maintained until a route change is completed "routeChangeComplete". Pre-condition: The scroll behaviour "smooth" must either be defined globally in css for the html element. From the hook provided this is done once in the effect-lifecycle, however a user defined configuration seems better, especially as the behaviour can be integrated into Next as described in the next step. Summary of the lifecycle: - Subscribe to routeChangeStart, routeChangeComplete events. - The route change starts Switch the scroll behavior to 'auto' Scroll immediately to the top and hold the value until the route change finishes. - The route change finishes Switch back to the default value specified in global css for the html element. For smooth-scrolling smooth, the behavior is 'smooth'. Hash changes are no route changes; the result is smooth scrolling on hash changes.
gurkerl83
requested review from
timneutkens,
ijjk,
shuding and
huozhi
as code owners
|
fixes #40719 |
|
Can someone review the pr, please? |
ijjk
force-pushed
the
canary
branch
2 times, most recently
from
e078ebe
to
6b863fe
Compare
11 tasks
|
Hi @gurkerl83, It should be fixed now. I'll close this PR, but thanks a ton for raising the issue, giving us repro, and trying to tackle it with PR. Open a new issue please if you still have issues with |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable smooth scroll in navigation attempts, restore scroll behaviour when the navigation completes.
The current implementation seems to be wrong, as the scroll behaviour "auto" immediately or during scrolling switches back to "smooth" or the globally defined behaviour of the html tag.
Local experiments showed that the scrolling behaviour "auto" must be initiated at the start of a route change "routeChangeStart" and must be maintained until a route change is completed "routeChangeComplete".
Pre-condition:
The scroll behaviour "smooth" must either be defined globally in css for the html element. From the hook provided this is done once in the effect-lifecycle, however a user defined configuration seems better, especially as the behaviour can be integrated into Next as described in the next step.
Summary of the lifecycle:
Bug
fixes #numbercontributing.mdFeature
fixes #numbercontributing.mdDocumentation / Examples
pnpm build && pnpm lint