Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chunk hash logic in hot-reloader for server components #43778

Merged
merged 5 commits into from
Dec 7, 2022
Merged

Conversation

shuding
Copy link
Member

@shuding shuding commented Dec 6, 2022

Previously we were assuming that serverOnlyChanges is the same as "server component changes". However that's not always true, as one can change a component from server component to client component, or vice versa, where the change affects both server and client builds, so serverOnlyChanges will be empty.

This PR fixes the logic by strictly hashing and comparing modules in the server layer. Note that I intentionally skipped the test as this fix isn't complete.

NEX-30

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • e2e tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shuding shuding merged commit b168c37 into canary Dec 7, 2022
@shuding shuding deleted the shu/fv98 branch December 7, 2022 12:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants