Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix windows path separator for app dir check #44087

Closed
wants to merge 1 commit into from
Closed

fix windows path separator for app dir check #44087

wants to merge 1 commit into from

Conversation

sokra
Copy link
Member

@sokra sokra commented Dec 16, 2022

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • e2e tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Dec 16, 2022
shuding
shuding reviewed Dec 16, 2022
View reviewed changes
Copy link
Member

@shuding shuding left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@huozhi fixed this already in the place of entry creation 👍

@huozhi
Copy link
Member

huozhi commented Dec 16, 2022

@sokra I've fixed in #44052 and #44011, should be good with latest canary now since we also add an integration test for azure pipeline. The root cause is explained in #44011

ijjk
ijjk previously approved these changes Dec 16, 2022
View reviewed changes
@ijjk ijjk dismissed their stale review December 16, 2022 17:08

Per above

@shuding shuding closed this Dec 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2023
@ForsakenHarmony ForsakenHarmony added the Turbopack Related to Turbopack with Next.js. label Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shuding shuding shuding left review comments

@ijjk ijjk ijjk left review comments

@timneutkens timneutkens Awaiting requested review from timneutkens

@padmaia padmaia Awaiting requested review from padmaia

@huozhi huozhi Awaiting requested review from huozhi

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sokra @huozhi @shuding @ijjk @ForsakenHarmony