Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix middleware 404 prefetch case #46782

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Fix middleware 404 prefetch case #46782

merged 1 commit into from
Mar 5, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 5, 2023

Ensures we properly generate the 404 page when a path is being prefetched with middleware configured.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Closes: #38239 (comment)

@samcx samcx self-requested a review March 5, 2023 02:06
@kodiakhq kodiakhq bot merged commit 9dd24a5 into vercel:canary Mar 5, 2023
@ijjk ijjk deleted the fix/not-found-404-prefetch branch March 5, 2023 03:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi approved these changes

@samcx samcx samcx approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@feedthejim feedthejim Awaiting requested review from feedthejim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Middleware + notFound is not working
3 participants
@ijjk @huozhi @samcx