Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example: Semantic-UI #4815

Merged
merged 3 commits into from
Jul 21, 2018
Merged

Update example: Semantic-UI #4815

merged 3 commits into from
Jul 21, 2018

Conversation

adrianmcli
Copy link
Contributor

The existing example currently does not work because of outdated usage patterns. This PR seeks to update these patterns to the latest recommended best practice while bumping versions.

Summary

  • Bumped version numbers in package.json;
  • Moved <link /> tag from pages/index.js to pages/_document.js as is recommended;
  • Replace individual css/font imports with import of minified CSS as is recommended;
  • Removed prop (no longer used) from <List /> element.

@timneutkens timneutkens merged commit 6ef7625 into vercel:canary Jul 21, 2018
@adrianmcli
Copy link
Contributor Author

@timneutkens thanks for merging!

@lock lock bot locked as resolved and limited conversation to collaborators Jul 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianmcli @timneutkens