Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update with-flow example #4835

Merged
merged 1 commit into from
Jul 25, 2018
Merged

update with-flow example #4835

merged 1 commit into from
Jul 25, 2018

Conversation

Tomekmularczyk
Copy link
Contributor

Changes:

  • updated packages
  • moved the content of layout to _app.js and created simple Page component
  • replaced import * as React because it is not necessary to import everything
  • moved next.js.flow to flow-typed as it is default directory for library definitions
  • updated the gif

@timneutkens timneutkens merged commit c090a57 into vercel:canary Jul 25, 2018
@vendramini
Copy link

vendramini commented Apr 9, 2019

@Tomekmularczyk could you answer to me, please?

If next.js injects React, why do we need to import it when enabling flow? Is mandatory?
I saw an error on IDE, but its compile well.

Can we avoid this import?

@Tomekmularczyk
Copy link
Contributor Author

@Tomekmularczyk could you answer to me, please?

If next.js injects React, why do we need to import it when enabling flow? Is mandatory?
I saw an error on IDE, but its compile well.

Can we avoid this import?

Yeah, I think so, you can remove it ;)

@vendramini
Copy link

Is there some way to fix the IDE (PhpStorm) error? Because flow forces me to import it.
Maybe some rule in .flowconfig?

I know this is not the place to answer officially, but if you know I appreciate it.

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants