fix bfcache restoration behavior #54198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
area: tests
created-by: Next.js team
ztanner
force-pushed
the
fix/bfcache-tree
branch
from
e7f2590
to
3749ec4
Compare
ztanner
requested review from
timneutkens,
ijjk,
shuding,
huozhi and
feedthejim
as code owners
timneutkens
approved these changes
Aug 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #54081 -- this was restoring the router tree improperly causing an error on bfcache hits
Had to override some default behaviors to prevent
forward/backin playwright from hanging indefinitely since no load event is firing in these casesFixes #54184
Closes NEXT-1528