-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(package): specify pnpm version in individual pkg.json #57012
Conversation
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
|
Failing test suitesCommit: bba3c07
Expand output● Font Optimization › Spread operator regression on
Read more about building and testing Next.js in contributing.md. |
I don't understand this part. Node.js doesn't have a default pnpm. It has to be installed somehow and we should only use corepack to install it. |
It was Digging bit, to let corepack uses latest version of pkg user could do like |
Corepack only reads Wouldn't the solution be to add a It sounds like you might have some other tool locally that is somehow reading |
The only config I have is using fnm to install node.js, confident I don't have other tools around. I admit I'm not entirely understanding the behavior of corepack though; it would definintly possible some local env setup might cause confusion. If you think this is not the correct workaround, fine to close and move forward. |
If you run If you install a new version of Node.js (for example, with fnm), then you will need to run that command again. I believe fnm has an option to always enable corepack Schniz/fnm#960 Also see https://styfle.dev/blog/corepack |
I'm fine to close this, but for the clarification I already did this (I never install pnpm globally) and still got this. Leaving comment as ref if someone else might hitting this in the future. |
What?
With latest rebase I started to see
run-tests
fails with errors likethat pnpm fails to set an option with
setPnpmResolutionMode
.Turned out, this is specific to the isolation test in a condition
This could be resolved in 2 ways
first approach would work, but probably a confusing experiences as locally it'll return valid pnpm version but only fails to create test. PR attempts to make things work by setting pkg.json's field.
Closes WEB-1797