Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove NODE_ENV override in standalone server #59005

Closed

Conversation

OlafurTorfi
Copy link

@OlafurTorfi OlafurTorfi commented Nov 28, 2023

What?

remove NODE_ENV override on standalone server

Why?

in order to be able to deploy next.js in different environments, using a single docker image.

Fixes

#58294

@OlafurTorfi OlafurTorfi requested review from S3Prototype and leerob and removed request for a team November 28, 2023 11:56
@OlafurTorfi OlafurTorfi changed the title remove NODE_ENV override ins standalone server remove NODE_ENV override in standalone server Nov 28, 2023
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If NODE_ENV is changed to anything other than production you severely regress on React server-side performance as it defaults to development. Also: this PR does not change Next.js.

@OlafurTorfi OlafurTorfi requested a review from a team as a code owner November 28, 2023 15:05
@leerob leerob closed this Dec 22, 2023
@github-actions github-actions bot added the locked label Jan 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants