Manually call sheet.seal() to avoid memory leaks on with-styled-components example #6107
+13
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasfeliciano
changed the title
mxstbr
approved these changes
Jan 24, 2019
|
Any idea why the test failed? 🤔 |
|
@lucasfeliciano the windows build is sometimes a little unstable, if at least one of the 2 node.js versions passes it's 👍 Especially when editing the examples. |
|
Thanks for clarifying. :) |
mydearxym
added a commit
to coderplanets/coderplanets_web
that referenced
this pull request
Jan 25, 2019
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was noticing some bad memory leak on my company's application and I ended up finding this github issue ( styled-components/styled-components#1624 ) .
This comment ( styled-components/styled-components#1624 (comment) ) caught my attention, which lead to this other issue on the repository of styled components website ( styled-components/styled-components-website#329 )
After applying the changes on my project I noticed a huge improvement on memory consumption.
So would be nice to update the example or start a discussion on how to solve this properly