Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove route event in componentWillUnmount #6196

Merged
merged 1 commit into from
Feb 3, 2019
Merged

Remove route event in componentWillUnmount #6196

merged 1 commit into from
Feb 3, 2019
+1 −1

Conversation

Sklpcc
Copy link
Contributor

@Sklpcc Sklpcc commented Feb 3, 2019

Router.events.off should be called instead of Router.events.on in componentWillInmount.

@timneutkens timneutkens merged commit 0e13d8c into vercel:canary Feb 3, 2019
@timneutkens
Copy link
Member

Great catch!

@lock lock bot locked as resolved and limited conversation to collaborators Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sklpcc @timneutkens