Skip to content

fix(create-next-app): add --no-import-alias for non-interactive #62035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 20, 2024
Merged

fix(create-next-app): add --no-import-alias for non-interactive #62035

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6687e87
fix(create-next-app): add --no-import-alias for non-interactive
kuzeykose Feb 14, 2024
03652ec
Merge branch 'canary' into canary
kuzeykose Feb 14, 2024
fa7bdad
Merge branch 'canary' into canary
ijjk Feb 14, 2024
e8c8d47
refactor(test): change import alias option
kuzeykose Feb 15, 2024
67aa49b
Merge branch 'canary' into canary
styfle Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/create-next-app/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,8 @@ async function run(): Promise<void> {
if (ciInfo.isCI) {
// We don't use preferences here because the default value is @/* regardless of existing preferences
program.importAlias = defaults.importAlias
} else if (process.argv.includes('--no-import-alias')) {
program.importAlias = defaults.importAlias
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently our non-interactive tests specify the --import-alias="@/*" arg but this seems like a good alternative so the default doesn't need to be known. Could you update one of the tests doing the previous behavior with this instead?

x-ref:

next.js/test/integration/create-next-app/templates-app.test.ts

Line 136 in ea65cb6

'--import-alias=@/*',

} else {
const styledImportAlias = blue('import alias')

Expand Down
2 changes: 1 addition & 1 deletion test/integration/create-next-app/templates-app.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ describe('create-next-app --app', () => {
'--app',
'--eslint',
'--src-dir',
'--import-alias=@/*',
'--no-import-alias',
],
{
cwd,
Expand Down
2 changes: 1 addition & 1 deletion test/integration/create-next-app/templates-pages.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ describe('create-next-app templates', () => {
'--eslint',
'--src-dir',
'--no-app',
`--import-alias=@/*`,
`--no-import-alias`,
],
{
cwd,
Expand Down