Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest @edge-runtime packages #62955

Merged
merged 4 commits into from Mar 6, 2024

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Mar 6, 2024

This upgrades to the latest edge-runtime packages as it includes exposing performance. This was reverted previously as our publishes were failing with a specific change that has since been removed upstream.

Closes NEXT-2730

@@ -1,4 +1,7 @@
export async function GET() {
// ensure performance is available in edge
console.log(performance.now())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better test would be to do this as the module's side-effect. Because different packages polyfill performance thus masking the problem once "everything is already imported".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@ijjk
Copy link
Member Author

ijjk commented Mar 6, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js update/bump-edge-runtime Change
buildDuration 14.6s 14.6s N/A
buildDurationCached 8s 6.7s N/A
nodeModulesSize 198 MB 198 MB N/A
nextStartRea..uration (ms) 426ms 448ms N/A
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js update/bump-edge-runtime Change
2453-HASH.js gzip 30.5 kB 30.5 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB N/A
8299-HASH.js gzip 5.04 kB 5.04 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 241 B N/A
main-HASH.js gzip 32.1 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 45.4 kB 45.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/bump-edge-runtime Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js update/bump-edge-runtime Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.2 kB 4.2 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.56 kB 6.56 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/bump-edge-runtime Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/bump-edge-runtime Change
index.html gzip 528 B 529 B N/A
link.html gzip 542 B 541 B N/A
withRouter.html gzip 524 B 523 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary ijjk/next.js update/bump-edge-runtime Change
edge-ssr.js gzip 95 kB 95.1 kB N/A
page.js gzip 3.06 kB 3.07 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary ijjk/next.js update/bump-edge-runtime Change
middleware-b..fest.js gzip 623 B 624 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 990 B 990 B
Next Runtimes
vercel/next.js canary ijjk/next.js update/bump-edge-runtime Change
app-page-exp...dev.js gzip 171 kB 171 kB
app-page-exp..prod.js gzip 96.7 kB 96.7 kB
app-page-tur..prod.js gzip 98.5 kB 98.5 kB
app-page-tur..prod.js gzip 92.9 kB 92.9 kB
app-page.run...dev.js gzip 149 kB 149 kB
app-page.run..prod.js gzip 91.4 kB 91.4 kB
app-route-ex...dev.js gzip 21.3 kB 21.3 kB
app-route-ex..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 15 kB 15 kB
app-route-tu..prod.js gzip 14.8 kB 14.8 kB
app-route.ru...dev.js gzip 21 kB 21 kB
app-route.ru..prod.js gzip 14.8 kB 14.8 kB
pages-api-tu..prod.js gzip 9.54 kB 9.54 kB
pages-api.ru...dev.js gzip 9.81 kB 9.81 kB
pages-api.ru..prod.js gzip 9.54 kB 9.54 kB
pages-turbo...prod.js gzip 22.3 kB 22.3 kB
pages.runtim...dev.js gzip 23 kB 23 kB
pages.runtim..prod.js gzip 22.3 kB 22.3 kB
server.runti..prod.js gzip 50.6 kB 50.6 kB
Overall change 949 kB 949 kB
build cache Overall increase ⚠️
vercel/next.js canary ijjk/next.js update/bump-edge-runtime Change
0.pack gzip 1.56 MB 1.56 MB N/A
index.pack gzip 105 kB 106 kB ⚠️ +1.13 kB
Overall change 105 kB 106 kB ⚠️ +1.13 kB
Diff details
Diff for middleware.js

Diff too large to display

Commit: dcc5ec1

@ijjk ijjk enabled auto-merge (squash) March 6, 2024 19:30
@ijjk ijjk disabled auto-merge March 6, 2024 19:43
@ijjk ijjk merged commit 67eca23 into vercel:canary Mar 6, 2024
60 of 62 checks passed
@ijjk ijjk deleted the update/bump-edge-runtime branch March 6, 2024 19:43
ijjk added a commit that referenced this pull request Mar 6, 2024
This upgrades to the latest edge-runtime packages as it includes
exposing `performance`. This was reverted previously as our publishes
were failing with a specific change that has since been removed
upstream.

Closes NEXT-2730
# Conflicts:
#	packages/next/package.json
#	test/e2e/opentelemetry/app/api/app/[param]/data/edge/route.ts
#	test/e2e/opentelemetry/pages/api/pages/[param]/edge.ts
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants