-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dynamic-import-node from the preset #7096
Merged
timneutkens
merged 2 commits into
vercel:canary
from
lfades:fix/remove-dynamic-import-node
Apr 21, 2019
Merged
Remove dynamic-import-node from the preset #7096
timneutkens
merged 2 commits into
vercel:canary
from
lfades:fix/remove-dynamic-import-node
Apr 21, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfades
requested review from
dav-is,
ijjk,
Timer and
timneutkens
as code owners
April 21, 2019 20:02
Stats from current PRClick to expand stats
Click to expand serverless stats
|
timneutkens
approved these changes
Apr 21, 2019
It should be moved to devDependencies, let's remove it here and add it back in that PR. |
timneutkens
approved these changes
Apr 21, 2019
Stats from current PRClick to expand stats
Click to expand serverless stats
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to this spectrum post.
I'm not removing the
babel-plugin-dynamic-import-node
package as it's going to be used by #7016