Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dynamic-import-node from the preset #7096

Merged
merged 2 commits into from
Apr 21, 2019

Conversation

lfades
Copy link
Member

@lfades lfades commented Apr 21, 2019

Related to this spectrum post.

I'm not removing the babel-plugin-dynamic-import-node package as it's going to be used by #7016

@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js fix/remove-dynamic-import-node Change
Build Duration 11.5s 11.2s -365ms
node_modules Size 43.9 MB 43.9 MB -216 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB
Client _app Size 2.49 kB 2.49 kB
Client _app gzip Size 1.04 kB 1.04 kB
Client _error Size 9.66 kB 9.66 kB
Client _error gzip Size 3.52 kB 3.52 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.28 kB
Client pages/link gzip Size 1.49 kB 1.49 kB
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24.4 kB
Client main gzip Size 7.89 kB 7.89 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.4 kB 59.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 580 kB 580 kB
Click to expand serverless stats
zeit/next.js canary lfades/next.js fix/remove-dynamic-import-node Change
Build Duration 12.1s 12.1s -6ms
node_modules Size 43.9 MB 43.9 MB -216 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB
Client _app Size 2.49 kB 2.49 kB
Client _app gzip Size 1.04 kB 1.04 kB
Client _error Size 9.66 kB 9.66 kB
Client _error gzip Size 3.52 kB 3.52 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.28 kB
Client pages/link gzip Size 1.49 kB 1.49 kB
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24.4 kB
Client main gzip Size 7.89 kB 7.89 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.4 kB 59.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Serverless pages/link Size 338 kB 338 kB
Serverless pages/link gzip Size 87.4 kB 87.4 kB
Serverless pages/index Size 330 kB 330 kB
Serverless pages/index gzip Size 85.5 kB 85.5 kB
Serverless pages/_error Size 331 kB 331 kB
Serverless pages/_error gzip Size 85.3 kB 85.3 kB
Serverless pages/routerDirect Size 331 kB 331 kB
Serverless pages/routerDirect gzip Size 85.5 kB 85.5 kB
Serverless pages/withRouter Size 331 kB 331 kB
Serverless pages/withRouter gzip Size 85.6 kB 85.6 kB ⚠️ +1 B
Build Dir Size 2.12 MB 2.12 MB

@timneutkens
Copy link
Member

It should be moved to devDependencies, let's remove it here and add it back in that PR.

@timneutkens timneutkens merged commit 0893780 into vercel:canary Apr 21, 2019
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary lfades/next.js fix/remove-dynamic-import-node Change
Build Duration 14.8s 14.5s -362ms
node_modules Size 43.9 MB 43.9 MB -11.1 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB
Client _app Size 2.49 kB 2.49 kB
Client _app gzip Size 1.04 kB 1.04 kB
Client _error Size 9.66 kB 9.66 kB
Client _error gzip Size 3.52 kB 3.52 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.28 kB
Client pages/link gzip Size 1.49 kB 1.49 kB
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24.4 kB
Client main gzip Size 7.89 kB 7.89 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.4 kB 59.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 580 kB 580 kB
Click to expand serverless stats
zeit/next.js canary lfades/next.js fix/remove-dynamic-import-node Change
Build Duration 15.3s 15.5s ⚠️ +122ms
node_modules Size 43.9 MB 43.9 MB -11.1 kB
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.5 kB 68.5 kB
Client _app Size 2.49 kB 2.49 kB
Client _app gzip Size 1.04 kB 1.04 kB
Client _error Size 9.66 kB 9.66 kB
Client _error gzip Size 3.52 kB 3.52 kB
Client pages/index Size 298 B 298 B
Client pages/index gzip Size 235 B 235 B
Client pages/link Size 3.28 kB 3.28 kB
Client pages/link gzip Size 1.49 kB 1.49 kB
Client pages/routerDirect Size 426 B 426 B
Client pages/routerDirect gzip Size 304 B 304 B
Client pages/withRouter Size 408 B 408 B
Client pages/withRouter gzip Size 293 B 293 B
Client main Size 24.4 kB 24.4 kB
Client main gzip Size 7.89 kB 7.89 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.4 kB 59.4 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 774 B 774 B
Serverless pages/link Size 338 kB 338 kB
Serverless pages/link gzip Size 87.4 kB 87.4 kB ⚠️ +1 B
Serverless pages/index Size 330 kB 330 kB
Serverless pages/index gzip Size 85.5 kB 85.5 kB ⚠️ +1 B
Serverless pages/_error Size 331 kB 331 kB
Serverless pages/_error gzip Size 85.3 kB 85.3 kB ⚠️ +1 B
Serverless pages/routerDirect Size 331 kB 331 kB
Serverless pages/routerDirect gzip Size 85.5 kB 85.5 kB ⚠️ +1 B
Serverless pages/withRouter Size 331 kB 331 kB
Serverless pages/withRouter gzip Size 85.6 kB 85.6 kB
Build Dir Size 2.12 MB 2.12 MB

@lfades lfades deleted the fix/remove-dynamic-import-node branch April 30, 2019 00:01
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants