Skip to content

[incomplete][test] Fail test on unasserted errors #80491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from
+8 −2
Draft

[incomplete][test] Fail test on unasserted errors #80491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions test/lib/browsers/playwright.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,16 +255,22 @@ export class Playwright<TCurrent = undefined> {
msg.args().map((handle) => handle.jsonValue().catch(() => {}))
).then((args) => ({ source: msg.type(), message: msg.text(), args }))
)

if (msg.type() === 'error') {
throw new Error(`Console error: ${msg.text()}`)
}
})
page.on('crash', () => {
console.error('page crashed')
page.on('crash', (page) => {
throw new Error('page crashed')
})
page.on('pageerror', (error) => {
console.error('page error', error)

if (opts?.pushErrorAsConsoleLog) {
pageLogs.push({ source: 'error', message: error.message, args: [] })
}

throw new Error('page error', { cause: error })
})
page.on('request', (req) => {
this.eventCallbacks.request.forEach((cb) => cb(req))
Expand Down
Loading