Fix configuration for node-notifier

[GerkinDev]

Update configuration for node-notifier@>=6.0.0 (latest being 9.0.0, and this PR also fixes shipping with those latest versions).
See changes in mikaelbr/node-notifier@54ddb7f.
As mentioned in npm documentation, peer dependencies are no longer installed by default. So I used it to constrain the supported version of node-notifier

[cmfcmf]

Hey,
adding a peer dependency will emit a warning for everyone that does not use node-notifier. To prevent that, you should mark the peer dependency as optional as described here:

• yarn: https://classic.yarnpkg.com/en/docs/package-json/#toc-peerdependenciesmeta
• npm: https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependenciesmeta
• Example: https://github.com/reduxjs/react-redux/blob/a9235530f4799dd4b2acb3cc65e9caf32efbc44b/package.json#L42-L49

[cmfcmf]

Hmm, I don't think adding node-notifier to optionalDependencies is the right move. This will install node-notifier for everyone that uses pkg. Instead, I think it would be better to add it as an optional peer dependency like I described above (that means that the node-notifier goes into peerDependencies and peerDependenciesMeta:

{
  "peerDependencies": {
    "node-notifier": ">=6.0.0"
  },
  "peerDependenciesMeta": {
    "node-notifier": {
      "optional": true
    }
  }
}

[GerkinDev]

Oh yeah my bad, I'm just learning that right now, thanks ! It will be useful for other packages ;) gonna fix this

[ThatOneCalculator]

Any update on this PR?

[leerob]

Thank you so much!

[SrBrahma]

I still have errors, as mentioned in mikaelbr/node-notifier#220 (comment). How can I fix it?

[GerkinDev]

@SrBrahma please refer to version ranges specified in https://github.com/vercel/pkg/blob/master/package.json#L61 : make sure that node-notifier@>=9.0.1 is installed, along with pkg@>4.4.9

[AliSawari]

@GerkinDev I have installed node-notifier and pkg versions correctly, but the problem still persists,
OS: Windows 10
Node: 16.15.1
output:

  The file must be distributed with executable as %2.
  %1: node_modules\node-notifier\vendor\notifu\notifu.exe
  %2: path-to-executable/notifier/notifu.exe
> Warning Cannot include file %1 into executable.
  The file must be distributed with executable as %2.
  %1: node_modules\node-notifier\vendor\notifu\notifu64.exe
  %2: path-to-executable/notifier/notifu64.exe
> Warning Cannot include file %1 into executable.
  The file must be distributed with executable as %2.
  %1: node_modules\node-notifier\vendor\terminal-notifier.app\Contents\MacOS\terminal-notifier
  %2: path-to-executable/notifier/terminal-notifier
> Warning Cannot include file %1 into executable.
  The file must be distributed with executable as %2.
  %1: node_modules\node-notifier\vendor\snoreToast\snoretoast-x64.exe
  %2: path-to-executable/notifier/snoretoast-x64.exe
> Warning Cannot include file %1 into executable.
  The file must be distributed with executable as %2.
  %1: node_modules\node-notifier\vendor\snoreToast\snoretoast-x86.exe
  %2: path-to-executable/notifier/snoretoast-x86.exe

[GerkinDev]

@AliSawari i think that since this PR has been merged, you should open a new issue or search for an already & still open one.