Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix counting of reallocations #8422

Merged
merged 2 commits into from
Jun 11, 2024
Merged

fix counting of reallocations #8422

merged 2 commits into from
Jun 11, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Jun 11, 2024

Description

reallocations were not counted correctly in the tracing

Testing Instructions

@sokra sokra requested a review from a team as a code owner June 11, 2024 12:06
@vercel Vercel
Copy link

vercel bot commented Jun 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 0:24am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 0:24am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 0:24am
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 0:24am
examples-gatsby-web ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 0:24am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 0:24am
examples-native-web ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 0:24am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 0:24am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 0:24am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview Jun 11, 2024 0:24am

@sokra sokra requested a review from arlyon June 11, 2024 12:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 11, 2024 •
edited
Loading

⚠️ This change may fail to build next-swc.

Logs 

error: failed to select a version for `swc_ecma_ast`.
    ... required by package `modularize_imports v0.68.15`
    ... which satisfies dependency `modularize_imports = "^0.68.15"` of package `turbopack-binding v0.1.0 (https://github.com/vercel/turbo?rev=bf1e23df7a5abc48960d70f4694bf225b66acc76#b37b9c6c)`
    ... which satisfies git dependency `turbopack-binding` (locked to 0.1.0) of package `next-swc-napi v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/napi)`
versions that meet the requirements `^0.113.7` are: 0.113.7

all possible versions conflict with previously selected packages.

  previously selected package `swc_ecma_ast v0.113.4`
    ... which satisfies dependency `swc_ecma_ast = "^0.113.1"` (locked to 0.113.4) of package `swc_core v0.92.5`
    ... which satisfies dependency `swc_core = "^0.92.5"` (locked to 0.92.5) of package `wasm v0.0.0 (/root/actions-runner/_work/turbo/turbo/packages/next-swc/crates/wasm)`

failed to select a version for `swc_ecma_ast` which could resolve this conflict

See job summary for details

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 11, 2024 •
edited
Loading

🟢 Turbopack Benchmark CI successful 🟢

Thanks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 11, 2024 •
edited
Loading

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit 943d6b5 into main Jun 11, 2024
55 of 58 checks passed
@sokra sokra deleted the sokra/tracing-realloc branch June 11, 2024 16:59
@sokra sokra mentioned this pull request Jun 12, 2024
Merged
sokra added a commit to vercel/next.js that referenced this pull request Jun 12, 2024
@sokra
use node js chunking context for evaluation (#66710)
4398e34 
### What?

Refactoring to use node.js chunking context for evaluation

see vercel/turborepo#8402

### Why?

### Turbopack changes

* vercel/turborepo#8422
* vercel/turborepo#8402
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
@sokra
fix counting of reallocations (vercel/turborepo#8422)
0499400 
### Description

reallocations were not counted correctly in the tracing

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
fix counting of reallocations (vercel/turborepo#8422)
6cb30cd 
### Description

reallocations were not counted correctly in the tracing

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
@sokra
fix counting of reallocations (vercel/turborepo#8422)
c0677c0 
### Description

reallocations were not counted correctly in the tracing

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
@sokra
fix counting of reallocations (vercel/turborepo#8422)
510dfe3 
### Description

reallocations were not counted correctly in the tracing

### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 14, 2024
@sokra @ForsakenHarmony
use node js chunking context for evaluation (#66710)
578a89c 
### What?

Refactoring to use node.js chunking context for evaluation

see vercel/turborepo#8402

### Why?

### Turbopack changes

* vercel/turborepo#8422
* vercel/turborepo#8402
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 15, 2024
@sokra @ForsakenHarmony
use node js chunking context for evaluation (#66710)
bedf18e 
### What?

Refactoring to use node.js chunking context for evaluation

see vercel/turborepo#8402

### Why?

### Turbopack changes

* vercel/turborepo#8422
* vercel/turborepo#8402
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
@sokra @ForsakenHarmony
use node js chunking context for evaluation (#66710)
fa694b7 
### What?

Refactoring to use node.js chunking context for evaluation

see vercel/turborepo#8402

### Why?

### Turbopack changes

* vercel/turborepo#8422
* vercel/turborepo#8402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

@arlyon arlyon Awaiting requested review from arlyon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sokra @kdy1