fix collectibles counting #8778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Skipped Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
| @@ -470,7 +470,7 @@ impl Backend for MemoryBackend { | |||
| trait_id: TraitTypeId, | |||
| reader: TaskId, | |||
| turbo_tasks: &dyn TurboTasksBackendApi<MemoryBackend>, | |||
| ) -> AutoMap<RawVc, i32> { | |||
| ) -> AutoMap<RawVc, i32, BuildHasherDefault<FxHasher>> { | |||
There was a problem hiding this comment.
Maybe create a type alias for this?
ForsakenHarmony
approved these changes
Jul 17, 2024
sokra
force-pushed
the
sokra/collectibles-couting
branch
from
32bf8ce
to
bb5880d
Compare
|
bgw
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 18, 2024
* vercel/turborepo#8767 <!-- Niklas Mischkulnig - Update Turbopack members in labeler --> * vercel/turborepo#8722 <!-- Niklas Mischkulnig - Use fs and vm for async chunk loading in Node --> * vercel/turborepo#8758 <!-- Benjamin Woodruff - Remove unused instant return value from `CaptureFuture` --> * vercel/turborepo#8760 <!-- Benjamin Woodruff - Delete dead raw_vc_set module --> * vercel/turborepo#8761 <!-- Benjamin Woodruff - Delete dead keyed_cell module --> * vercel/turborepo#8755 <!-- Donny/강동윤 - feat: Enable tree shaking in next.js --> * vercel/turborepo#8769 <!-- Benjamin Woodruff - Rewrite IdFactory and IdFactoryWithReuse --> * vercel/turborepo#8771 <!-- Benjamin Woodruff - Add u64 ExecutionId type --> * vercel/turborepo#8735 <!-- Tobias Koppers - turbo-tasks this calls --> * vercel/turborepo#8775 <!-- Tobias Koppers - improve failsafe_analyse --> * vercel/turborepo#8776 <!-- Tobias Koppers - notify tasks when collectibles change --> * vercel/turborepo#8778 <!-- Tobias Koppers - fix collectibles counting --> * vercel/turborepo#8736 <!-- Tobias Koppers - Refactor task arguments to be a single one --> * vercel/turborepo#8737 <!-- Tobias Koppers - remove ConcreteTaskInput in favor of the original rust datatypes -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description fix a bunch of cases where collectibles were not correctly counted ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description fix a bunch of cases where collectibles were not correctly counted ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description fix a bunch of cases where collectibles were not correctly counted ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description fix a bunch of cases where collectibles were not correctly counted ### Testing Instructions <!-- Give a quick description of steps to test your changes. -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 14, 2024
* vercel/turborepo#8767 <!-- Niklas Mischkulnig - Update Turbopack members in labeler --> * vercel/turborepo#8722 <!-- Niklas Mischkulnig - Use fs and vm for async chunk loading in Node --> * vercel/turborepo#8758 <!-- Benjamin Woodruff - Remove unused instant return value from `CaptureFuture` --> * vercel/turborepo#8760 <!-- Benjamin Woodruff - Delete dead raw_vc_set module --> * vercel/turborepo#8761 <!-- Benjamin Woodruff - Delete dead keyed_cell module --> * vercel/turborepo#8755 <!-- Donny/강동윤 - feat: Enable tree shaking in next.js --> * vercel/turborepo#8769 <!-- Benjamin Woodruff - Rewrite IdFactory and IdFactoryWithReuse --> * vercel/turborepo#8771 <!-- Benjamin Woodruff - Add u64 ExecutionId type --> * vercel/turborepo#8735 <!-- Tobias Koppers - turbo-tasks this calls --> * vercel/turborepo#8775 <!-- Tobias Koppers - improve failsafe_analyse --> * vercel/turborepo#8776 <!-- Tobias Koppers - notify tasks when collectibles change --> * vercel/turborepo#8778 <!-- Tobias Koppers - fix collectibles counting --> * vercel/turborepo#8736 <!-- Tobias Koppers - Refactor task arguments to be a single one --> * vercel/turborepo#8737 <!-- Tobias Koppers - remove ConcreteTaskInput in favor of the original rust datatypes -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 15, 2024
* vercel/turborepo#8767 <!-- Niklas Mischkulnig - Update Turbopack members in labeler --> * vercel/turborepo#8722 <!-- Niklas Mischkulnig - Use fs and vm for async chunk loading in Node --> * vercel/turborepo#8758 <!-- Benjamin Woodruff - Remove unused instant return value from `CaptureFuture` --> * vercel/turborepo#8760 <!-- Benjamin Woodruff - Delete dead raw_vc_set module --> * vercel/turborepo#8761 <!-- Benjamin Woodruff - Delete dead keyed_cell module --> * vercel/turborepo#8755 <!-- Donny/강동윤 - feat: Enable tree shaking in next.js --> * vercel/turborepo#8769 <!-- Benjamin Woodruff - Rewrite IdFactory and IdFactoryWithReuse --> * vercel/turborepo#8771 <!-- Benjamin Woodruff - Add u64 ExecutionId type --> * vercel/turborepo#8735 <!-- Tobias Koppers - turbo-tasks this calls --> * vercel/turborepo#8775 <!-- Tobias Koppers - improve failsafe_analyse --> * vercel/turborepo#8776 <!-- Tobias Koppers - notify tasks when collectibles change --> * vercel/turborepo#8778 <!-- Tobias Koppers - fix collectibles counting --> * vercel/turborepo#8736 <!-- Tobias Koppers - Refactor task arguments to be a single one --> * vercel/turborepo#8737 <!-- Tobias Koppers - remove ConcreteTaskInput in favor of the original rust datatypes -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 16, 2024
* vercel/turborepo#8767 <!-- Niklas Mischkulnig - Update Turbopack members in labeler --> * vercel/turborepo#8722 <!-- Niklas Mischkulnig - Use fs and vm for async chunk loading in Node --> * vercel/turborepo#8758 <!-- Benjamin Woodruff - Remove unused instant return value from `CaptureFuture` --> * vercel/turborepo#8760 <!-- Benjamin Woodruff - Delete dead raw_vc_set module --> * vercel/turborepo#8761 <!-- Benjamin Woodruff - Delete dead keyed_cell module --> * vercel/turborepo#8755 <!-- Donny/강동윤 - feat: Enable tree shaking in next.js --> * vercel/turborepo#8769 <!-- Benjamin Woodruff - Rewrite IdFactory and IdFactoryWithReuse --> * vercel/turborepo#8771 <!-- Benjamin Woodruff - Add u64 ExecutionId type --> * vercel/turborepo#8735 <!-- Tobias Koppers - turbo-tasks this calls --> * vercel/turborepo#8775 <!-- Tobias Koppers - improve failsafe_analyse --> * vercel/turborepo#8776 <!-- Tobias Koppers - notify tasks when collectibles change --> * vercel/turborepo#8778 <!-- Tobias Koppers - fix collectibles counting --> * vercel/turborepo#8736 <!-- Tobias Koppers - Refactor task arguments to be a single one --> * vercel/turborepo#8737 <!-- Tobias Koppers - remove ConcreteTaskInput in favor of the original rust datatypes -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix a bunch of cases where collectibles were not correctly counted
Testing Instructions