Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missed contents of source identifiers into local ones #1633

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Add missed contents of source identifiers into local ones #1633

merged 1 commit into from
Jan 19, 2021

Conversation

sdamghan
Copy link
Member

@sdamghan sdamghan commented Jan 15, 2021 •
edited
Loading

Support signed values for arithmetic shift

Odin does not completely support signed values yet. As already the implementation of arithmetic shift operation has been done completely, a solution is proposed to have the signed values shift operation support.

Description

This commit resolves the missed hierarchical contents for IDENTIFIERs. Odin creates a new IDENTIFIER ast_node when faces global or local variable usage. However, critical information like variable signedness is not transferred to the new node. So, the added code addresses this problem when Odin reduces expressions.

Related Issue

Commits #1560 and #1468
Issue #38

Motivation and Context

How Has This Been Tested?

1. make test (ODIN-II)
2. Basic Regression Tests
3. Strong Regression Test
4. Basic Valgrind Memory Tests (also, Valgrind memory tests for all other regression suits)
5. Sanitized Basic Regression Tests
6. Odin-II Micro Tests

Types of changes

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@github-actions github-actions bot added the Odin Odin II Logic Synthesis Tool: Unsorted item label Jan 15, 2021
@sdamghan sdamghan force-pushed the asr_signed_values branch 2 times, most recently from 2da88da to bb2f49f Compare January 17, 2021 15:19
@sdamghan
Odin:
f2d12b8 
   - resolve missed hierarchical reference contents for IDENTIFIERS

   - support signed values in arithmetic shift left

   - update documentation
@sdamghan sdamghan merged commit 991b114 into master Jan 19, 2021
@sdamghan sdamghan deleted the asr_signed_values branch January 19, 2021 15:56
@sdamghan
Copy link
Member Author

Hi @vaughnbetz ,
I see an unsuccessful check for this PR related to the VTR weekly test; however, the build log files (link) under the artifact tab are empty! Would you please let me know how I can find the errors log?

@vaughnbetz
Copy link
Contributor

I'm not sure. I see only green (all tests passed) under this PR when I click on checks, so I'm not sure what error you're referring to.

@sdamghan
Copy link
Member Author

sdamghan commented Jan 26, 2021 •
edited
Loading

I referred to the red cross mark for my last commit (Merge pull request #1633 ...) in the master branch (here). It shows an unsuccessful check for the VtR Weekly Test!

@vaughnbetz
Copy link
Contributor

Ah, I see, thanks. I'm not sure what happened; the log is empty as far as I can see too. I know the CI system has been modified a lot recently to move to github actions. @litghost: any idea, and do you think this is a real issue that needs investigation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Odin Odin II Logic Synthesis Tool: Unsorted item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdamghan @vaughnbetz @symbiflow-robot