Auto-comment and indentation improvements

[acr4]

Please consider the commits in this pull-request to enhance behavior of auto-comment and indentation of various Verilog and SV constructs.

[wsnyder]

I'd prefer to track changes on veripool.org to keep things contained.

Anyhow first four are merged to trunk.

The last one I'm not sure of. I'm curious what is the case that is breaking with this, and also why only include is being fixed and none of the other preproc directives that have arguments?

Thanks for the work here, it's needed some love. I'd caution that we don't have any regression tests on the autocomment code; it would be great to have an improvement to 0test.el that updated the endcomments on every test, so we could regress this autocomment code.

[acr4]

Thanks for accepting the first four. I originally tested the fifth using a
complete "ifdef ...endif" block before the property, but apparently
failed to test the define ... case or having the property inside the ifdef. Those indeed fail to correct the indentation.

Let me think a little more and get back to you on these...

On Mon, Oct 27, 2014 at 1:55 PM, W Snyder notifications@github.com wrote:

I'd prefer to track changes on veripool.org to keep things contained.

Anyhow first four are merged to trunk.

The last one I'm not sure of. I'm curious what is the case that is
breaking with this, and also why only include is being fixed and none of
the other preproc directives that have arguments?

Thanks for the work here, it's needed some love. I'd caution that we don't
have any regression tests on the autocomment code; it would be great to
have an improvement to 0test.el that updated the endcomments on every test,
so we could regress this autocomment code.

—
Reply to this email directly or view it on GitHub
#2 (comment).

[acr4]

Hi Wilson,
Here's another take on fixing property indentation after preproc directives:

acr4@906ae28
<edit: new commit via force-push to clean-up my terrible spelling>

Still no unit tests, but all of the IEEE 1800-2012 directives are accounted
for (the ones listed in Section 22)

On Mon, Oct 27, 2014 at 2:26 PM, Alex C. Reed, IV acreed4@gmail.com wrote:

Thanks for accepting the first four. I originally tested the fifth using
a complete "ifdef ...endif" block before the property, but apparently
failed to test the define ... case or having the property inside the ifdef. Those indeed fail to correct the indentation.

Let me think a little more and get back to you on these...

On Mon, Oct 27, 2014 at 1:55 PM, W Snyder notifications@github.com
wrote:

I'd prefer to track changes on veripool.org to keep things contained.

Anyhow first four are merged to trunk.

The last one I'm not sure of. I'm curious what is the case that is
breaking with this, and also why only include is being fixed and none of
the other preproc directives that have arguments?

Thanks for the work here, it's needed some love. I'd caution that we
don't have any regression tests on the autocomment code; it would be great
to have an improvement to 0test.el that updated the endcomments on every
test, so we could regress this autocomment code.

—
Reply to this email directly or view it on GitHub
#2 (comment).

[wsnyder]

Committed, just made small change as `begin_keywords needs to support quotes. Thanks.