-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add upgrade
command to support self upgrade (#239)
#239
Conversation
commit 830d706 Author: ankit-pn <miankitsingh@gmail.com> Date: Wed Jan 31 09:21:13 2024 +0530 fix: fomat the file and used internal decompressor commit fd0eb8b Author: ankit-pn <miankitsingh@gmail.com> Date: Tue Jan 30 16:27:05 2024 +0530 feat: add self -upgrade feature. commit f478217 Author: ankit-pn <miankitsingh@gmail.com> Date: Mon Jan 29 20:19:27 2024 +0530 fix: mac arm64 installation
Is it possible to introduce some third-party libraries or refer to the implementation of third-party libraries to complete this function? https://github.com/inconshreveable/go-update This go version management tool supports self-update, and everything works fine when I use it under window. |
I don't like to introduce too many third party packages. |
can refer to related implementations |
There is an issue. We need to ask for administrator privileges when upgrading for I've fixed the issue, but I don't have write access to your repository, so I can't commit at the moment. |
I have invited you as collaborator. Here is my repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested it on Windows.
I have diligently read about the libraries related to self-update, and the tool you mentioned just relies on one of them (voidint/go-update). sanbornm/go-selfupdate (The above is completely the same.) I would prefer the current handling method, which actually removes the old executable with the cmd tool of Windows itself. |
upgrade
command to support self upgrade (#239)
@yanecc Hi, are you interested in joining |
Sure, It's my pleasure 😎 |
I have implemented the Windows part based on @ankit-pn's work at #38 and resolved the conflicts, it is now able to work as expected, namely upgrade to the latest version 0.4.1.