Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpServerRequest headers names are not case insensitive #57

Closed
ddossot opened this issue Oct 2, 2013 · 2 comments
Closed

HttpServerRequest headers names are not case insensitive #57

ddossot opened this issue Oct 2, 2013 · 2 comments

Comments

@ddossot
Copy link

ddossot commented Oct 2, 2013

org.vertx.scala.core.http.HttpServerRequest uses Scala's collection.mutable.MultiMap which is not case insensitive, preventing headers to be correctly retrieved when the case in their names don't match.

In other vert.x langs, this works as expected, ie header names are case-insensitive.

@Narigo
Copy link
Member

Narigo commented Oct 4, 2013

This will change with #51 to use org.vertx.java.core.MultiMap internally. It would be great if you could check out the branch I'm working on (Narigo/complete-api), to see if it's still an issue there. And I'd be happy to have a pull request with a test for this :)

Thanks!

@galderz
Copy link
Contributor

galderz commented Mar 13, 2014

This has been fixed in #136 and we make sure header names are lower cased internally.

@galderz galderz closed this as completed Mar 13, 2014
@galderz galderz added this to the 1.0.0-RC1 milestone Mar 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants