Support for chown and chownSync #118
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
| @@ -124,6 +124,18 @@ final class FileSystem private[scala] (val asJava: JFileSystem) extends Self { | |||
| wrap(asJava.chmodSync(path, perms, dirPerms)) | |||
|
|
|||
| /** | |||
| * Change the ownership on the file represented by {@code path} to {@code user} and {code group}, asynchronously. | |||
Signed-off-by: Joern Bernhardt <joern.bernhardt@googlemail.com>
|
fixed scaladoc and serious copy and paste error |
|
Fixed, I did a small modification on the Scaladoc |
|
Fixes issue #106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Option[String] instead of having parameters which are String with null values like Vert.x core.
Tests are only checking for errors as you might not be able to change ownership while running tests anyways. This was discussed with Norman in IRC - this is the same as Vert.x core testing right now.