gh-134 HttpServerRequest.uploadHandler should take a function #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes. :) |
|
Actually, there's more to this... there's no HttpServerFileUpload in the scala side. More to come... |
| req.endHandler({ | ||
| val attrs = req.formAttributes() | ||
| attributeCount.set(attrs.size) | ||
| System.out.println("attr is " + attrs.get("framework")) |
…ler() * HttpServerRequest.uploadHandler should take a function with the scala version of HttpServerFileUpload * Added tests to verify form and file upload * MultiMap adapter needs to be shallow copy over the Vert.x MultiMap. Otherwise, changes to underlying Vert.x MultiMap were not visibible to Scala consumers.
|
@Narigo I've updated the PR, particularly in the area of wrapping Vert.x's multi map. The new wrapper is a shallow, lazy, one which can check the underlying multi map for updated values...etc. The tests added by this PR were failing without this. |
|
I've added a commit to upgrade to Vert.x 2.1RC1 |
|
Idea for tests: Upper/Lowercase adding removing headers. |
|
Integrated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.