Project Compiles, improve building, Add testing and HttpServer, FileSystem, NetServer and RecordParser Implementations. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
method from createService to newService, NetClient SSL support
…ure handling, so no need for temporal storing in the event bus state. - Pubsub test case added
…builtin mutable.MultiMap.
Changed signatures for HttpServerRequest.{headers, params} and HttpServerResponse.{headers, trailers}
from mutable.MultiMap[Any, Any] to mutable.MultiMap[String, String] since internally a key-pair of string
values is stored. The implicit conversion creates a new MultiMap instance, hence any mutation done to that
instance will not affect the internal representation. Say you want to add additional headers/trailer to
HttpServerResponse, you should use put{Header, Trailer} methods provided rather than adding them manually to
the MultiMap instance acquired via headers/trailers methods.
Conflicts:
src/main/scala/org/vertx/scala/core/http/HttpServerResponse.scala
|
So does this PR supersede the other one, or require it? |
|
OK folks, I'll merge this today if you can all confirm that you have completed an Eclipse CLA, as per my email to the group: [vertx:9689] mod-lang-scala PR7 |
|
3 CLAs confirmed, PR 7 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small resume of what was done in this pulll request:
Added then,
Thanks,
Edgar, Ranie & Nicolas