Eventbus send with timeout #77
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've just added another commit to introduce the Message.fail() method that the Java API now provides, too |
| @@ -30,71 +61,160 @@ class EventBus(protected[this] val internal: JEventBus) extends VertxWrapper { | |||
|
|
|||
| sealed private trait SendOrPublish | |||
| private case class Publish(address: String, value: MessageData) extends SendOrPublish | |||
| private case class Send[X](address: String, value: MessageData, replyHandler: Option[Handler[JMessage[X]]]) extends SendOrPublish | |||
| private case class Send[X](address: String, value: MessageData, | |||
| replyHandler: Option[Either[Handler[JMessage[X]], Handler[AsyncResult[JMessage[X]]]]]) | |||
There was a problem hiding this comment.
These types are getting a bit too verbose. What about we use type aliases to make them more readable?
There was a problem hiding this comment.
I don't really care as these are only used in this class and cannot be accessed from outside.
|
Minor things, the rest looks fine. |
|
@galderz if you're okay with this now, then please merge. I'll add the PR for the unregistering handler right away then. |
| vertx.eventBus.sendWithTimeout("hello", "late-reply-within-timeout", 100, { | ||
| case Success(result) => fail("Should not receive a message within time, but got one: " + result.body) | ||
| case Failure(ex) => | ||
| assertThat("exception should be of kind ReplyException", ex, instanceOf(classOf[ReplyException])) |
There was a problem hiding this comment.
I think you can leave the String message out (up to you...) e.g.
assertThat(new Exception, instanceOf(classOf[ArrayIndexOutOfBoundsException]))
Throws:
Exception in thread "main" java.lang.AssertionError:
Expected: an instance of java.lang.ArrayIndexOutOfBoundsException
got: <java.lang.Exception>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something for 2.1M2-SNAPSHOT since there was a bugfix for send / reply with timeouts. Please review and merge if everything okay.