Skip to content

Add sendFile methods which takes a result handler. #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

raniejade
Copy link
Contributor

Resolves #83.

@Narigo
Copy link
Member

Narigo commented Nov 9, 2013

Could you add a test for that, please? :)

Does the AsyncResultHandler fire after the file is received completely by
the user or as soon as the sending of the file starts?
Am 09.11.2013 05:50 schrieb "Ranie Jade Ramiso" notifications@github.com:

Resolves #83 #83.

You can merge this Pull Request by running

git pull https://github.com/raniejade/mod-lang-scala issue-#83

Or view, comment on, or merge it at:

#90
Commit Summary

  • Add sendFile methods which takes a result handler.

File Changes

Patch Links:

@raniejade
Copy link
Contributor Author

Sure thing :).

@galderz
Copy link
Contributor

galderz commented Nov 14, 2013

Yeah, please add tests. Closing the PR until tests have been added.

Does the AsyncResultHandler fire after the file is received completely by the user or as soon as the sending of the file starts?

@Narigo I guess that's something that depends on the Vert.x internals?

@galderz galderz closed this Nov 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please implement new sendFile methods which takes a result handler
3 participants