Fix losing query parameters for SSL requests (issue #563) #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsegismont
reviewed
Mar 22, 2017
| testTLS(clientSSL, serverSSL, requestProvider, null); | ||
| } | ||
|
|
||
| private void testTLS(boolean clientSSL, boolean serverSSL, Function<WebClient, HttpRequest<Buffer>> requestProvider, Function<HttpServerRequest, Void> serverAssertions) throws Exception { |
There was a problem hiding this comment.
Could you please change Function<HttpServerRequest, Void> serverAssertions to Consumer<HttpServerRequest> serverAssertions ?
There was a problem hiding this comment.
Of course! Done.
|
@svenjacobs Thanks! Just a minor comment but overall looks good to me. |
|
Supersedes #562 |
|
LGTM. @pmlopes OK to merge? |
|
@tsegismont @pmlopes Any news on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #563