Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd add extra parameters #222

Closed
wants to merge 1 commit into from
Closed

Conversation

bangsun1234
Copy link

Startup parameter added file path that can configure tag/edgeType.
Priority: Startup Parameter > Configuration File. The default parameter is configuration file.
Cmd parameter style like: {tag name/edgeType name}={path}, example: person=/home/user/person.csv,Support for multiple parameters, multiple same tag/edgeType are not supported.

Startup command like:
./nebula-importer --config <yaml_config_file_path> <tag_name>=<new_data_path01> <edgetype_name>=<new_data_path02>

…dgeType. Priority: Startup Parameter > Configuration File
@CLAassistant
Copy link

CLAassistant commented Nov 22, 2022

CLA assistant check
All committers have signed the CLA.

@veezhang
Copy link
Contributor

veezhang commented Dec 7, 2022

@bangsun1234 Thanks a lot for your contribution!
In my opinion, this approach may not be general enough to support more parameter configurations. What do you think?

@veezhang
Copy link
Contributor

veezhang commented Dec 7, 2022

Maybe something like JSON Patch is more appropriate.

@veezhang
Copy link
Contributor

veezhang commented Dec 7, 2022

Or support environment variable in configuration file, does this solve your proble?

@veezhang
Copy link
Contributor

veezhang commented Jan 9, 2023

We will close it, thank you for your contribution.
If need, you can open it again.

@veezhang veezhang closed this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants