Support "show parts" command #1086
Conversation
zhangguoqing
force-pushed
the
show-parts
branch
2 times, most recently
from
7102a05
to
aeeb9ae
Compare
zhangguoqing
changed the title
|
Unit testing failed. |
|
Jenkins go |
|
Unit testing failed. |
of course! |
|
Jenkins go |
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
|
Jenkins go |
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
You could post it in the summary. |
Thanks, I have updated the summary of this PR. |
I means you could post the results displayed by console in this summary. |
Done! |
zhangguoqing
requested review from
critical27,
CPWstatic,
darionyaphet,
laura-ding and
zlcook
src/common/network/NetworkUtils.cpp
Outdated
| std::string addrStr = network::NetworkUtils::ipFromHostAddr(host); | ||
| int32_t port = network::NetworkUtils::portFromHostAddr(host); | ||
| std::string portStr = folly::to<std::string>(port); | ||
| hostsString += addrStr + ":" + portStr + ", "; |
There was a problem hiding this comment.
folly::stringPrintf("%s:%d,", addrStr.c_str(), port);
|
Unit testing passed. |
|
Unit testing failed. |
| namespace nebula { | ||
| namespace meta { | ||
|
|
||
| void ListPartsProcessor::process(const cpp2::ListPartsReq& req) { |
There was a problem hiding this comment.
Do you think we can support list the partition specified in console? If we have to many partitions, it's hard to look for a single partition.
There was a problem hiding this comment.
Agreed. We'd better support to show some part information specified too.
There was a problem hiding this comment.
The result is sorted by partition ID.
There was a problem hiding this comment.
Of course, we could open another pr for it.
There was a problem hiding this comment.
Yep, would it be better to use the LIMIT clause?
|
Jenkins go! |
| @@ -306,6 +306,19 @@ StatusOr<std::vector<HostAddr>> NetworkUtils::toHosts(const std::string& peersSt | |||
| return hosts; | |||
| } | |||
|
|
|||
| std::string NetworkUtils::toHosts(const std::vector<HostAddr>& hosts) { | |||
There was a problem hiding this comment.
concatHosts may be a better func name to explain this?
There was a problem hiding this comment.
Thx. I prefer the toHosts function overload.
There was a problem hiding this comment.
IMO, the Concat generally refers to joining the same kind of things and returning the original form. For example, joining multiple strings returns a string. There is a formal shift here(HostAddr to String, with the meaning of convert to), not a simple join or concat.
|
Unit testing passed. |
2 similar comments
|
Unit testing passed. |
|
Unit testing passed. |
|
Unit testing passed. |
|
subtask of #724 |
ListPartsProcessorto get all partitions' information(id, leader, peers, losts) of one graph space.SHOW PARTScommand can show the results displayed by console, after doingUSE space_name.close #930
Example:
Init and start the nebula graph cluster:
Create the graph spaces(named myspace) with 9 partitions and 3 replicas:
Show the hosts with myspace:
Show parts of myspace, before leader election:
Show parts of myspace, after leader election:
Stop the storaged 172.25.61.1:44500:
Wait for the expired_threshold_sec(10 * 60) seconds:
Start the storaged 172.25.61.1:44500 again: